Skip to content

fix(web): expose the modern credential test icon - #826

Merged
tbphp merged 1 commit into
mainfrom
tbphp/modern-inline-credential-test
Oct 5, 2026
Merged

tbphp merged 1 commit into
mainfrom
tbphp/modern-inline-credential-test

Conversation

@tbphp

@tbphp tbphp commented Oct 5, 2026

Copy link
Copy Markdown
Owner

关联 Issue / Related Issue

Refs #720

变更内容 / Change Content

  • Bug 修复 / Bug fix
  • 新功能 / New feature
  • 其他改动 / Other changes

Move the modern API-key model test action out of the overflow menu and display it as a single icon immediately to the right of the view-details button. Reuse the existing tooltip, disabled state, and test action.

This change is limited to the modern API-key action layout. It adds no menu customization and leaves the classic UI and subscription-account actions unchanged. There are no API or data-migration changes.

Validation: make check passed. No public documentation changes are needed for this UI-only adjustment.

自查清单 / Checklist

  • 我已运行 make check,或在说明中写明无法运行的原因和未验证范围。 / I ran make check, or documented why it could not run and what remains unverified.
  • 本 PR 范围聚焦,未包含无关改动。 / This PR is focused and contains no unrelated changes.
  • 我已更新必要的公开文档或发布说明。 / I updated any required public documentation or release notes.
  • 我已确认提交、日志和测试数据不包含敏感信息。 / I confirmed that commits, logs, and fixtures contain no sensitive data.
  • 如适用,我已说明兼容性或数据迁移影响。 / Where applicable, I documented compatibility or data-migration impact.

Copilot AI balanced review requested due to automatic review settings October 5, 2026 11:39

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@tbphp tbphp self-assigned this Oct 5, 2026
@tbphp tbphp added the enhancement New feature or request label Oct 5, 2026
@tbphp tbphp added this to the v2.0.0 milestone Oct 5, 2026
@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: QUIET
  • Plan: Advanced
  • Run ID: 612f29bb-e503-4152-aa2d-85d0758d935d
📥 Commits

Reviewing files that changed from the base of the PR and between b88b395 and 5a8ab08.

📒 Files selected for processing (1)
  • web/src/frontends/modern/features/groups/CredentialCardActions.vue

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

更多操作菜单不再提供测试操作。非订阅凭证卡片显示测试按钮;订阅凭证卡片不显示该按钮。点击测试按钮时,组件发送值为 test 的 action 事件,且按钮禁用状态沿用 disabled 属性。

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 5a8ab

Testing remains available through a direct button on non-subscription credential cards. The supplied context indicates no actionable regression or specific merge-blocking risk.

Architecture Summary

Architecture risk: 🔵 Low · up to 5a8ab

The change affects 1 system.

Changed systems: web

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — web (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in web/src/frontends/modern/features/groups/CredentialCardActions.vue: 移除了非订阅凭证的测试菜单项;菜单中的 test 操作不再提供。
  • observed — Modified behavior in web/src/frontends/modern/features/groups/CredentialCardActions.vue: 新增测试按钮,仅在 !subscription 时显示;点击时触发 action 事件并传递 test,禁用状态沿用 disabled 属性。
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed 标题简洁且准确,说明了将现代凭证测试图标显示出来这一主要变更。
Description check ✅ Passed 描述包含关联 Issue、变更内容和自查清单,并说明验证结果及无需更新文档的原因。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tbphp
tbphp merged commit 5c6ec0f into main Oct 5, 2026
12 checks passed
@tbphp
tbphp deleted the tbphp/modern-inline-credential-test branch October 5, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants