Repository navigation
test: prove exact compiled correction output - #68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The learning acceptance test executed a separate
printfargv while storing a shell command with different escaping. It could therefore pass without proving that the compiled replacement produced the demonstrated output.Use one command string for annotation, compilation and execution; read the replacement back from the actual compiled thesaurus, execute that exact string, and verify its saved stdout. This changes one test file only; released binaries and immutable tags are unchanged.
Validation: all six real macOS stdio/CLI contracts pass against the downloaded agent 1.21.22 and MCP 1.21.22-rc.1 binaries, with exact compiled-command output retained. An isolated Linux run against the same public release pair also passes the exact-command check, storage/restart checks, 20 compile/query cycles and held-lock refusal/recovery.
cargo fmt --all --checkand targeted Clippy with-D warningspass. Independent review reran the six macOS contracts successfully. Earlier evidence is retained with the escaping limitation documented.