Skip to content

test: prove exact compiled correction output #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexMikhalev merged 1 commit into from
Oct 15, 2026
Merged

test: prove exact compiled correction output #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions crates/terraphim_mcp_server/tests/test_mcp_agent_contract.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,15 +309,16 @@ async fn actual_failure_annotation_explicit_rule_compile_and_synonym_export() ->
let failed = Command::new("printf").arg("%Z").output().await?;
assert_eq!(failed.status.code(), Some(1));
let error = String::from_utf8(failed.stderr)?;
let corrected = Command::new("printf")
.args(["%s\n", "reviewed correction"])
let corrected_command = r#"printf '%s\n' 'reviewed correction'"#;
let corrected = Command::new("/bin/sh")
.args(["-c", corrected_command])
.output()
.await?;
assert!(corrected.status.success());
assert_eq!(corrected.stdout, b"reviewed correction\n");
evidence(
"agent-learning-actual-execution",
&json!({"failed":{"argv":["printf","%Z"],"exit":failed.status.code(),"stderr":error},"corrected":{"argv":["printf","%s\n","reviewed correction"],"exit":corrected.status.code(),"stdout":String::from_utf8(corrected.stdout)?}}),
&json!({"failed":{"argv":["printf","%Z"],"exit":failed.status.code(),"stderr":error},"corrected":{"argv":["/bin/sh","-c",corrected_command],"exit":corrected.status.code(),"stdout":String::from_utf8(corrected.stdout)?}}),
)?;
let captured = call(
&client,
Expand All @@ -332,7 +333,6 @@ async fn actual_failure_annotation_explicit_rule_compile_and_synonym_export() ->
error.trim()
);
assert_eq!(data(&captured)["exit_code"], 1);
let corrected_command = "printf '%s\\n' 'reviewed correction'";
let annotated = call(
&client,
"agent_learning_correct",
Expand Down Expand Up @@ -371,6 +371,25 @@ async fn actual_failure_annotation_explicit_rule_compile_and_synonym_export() ->
.display(),
corrected_command
);
let stored_command = disk
.get(&terraphim_types::NormalizedTermValue::from("printf '%Z'"))
.unwrap()
.display()
.to_string();
let stored_execution = Command::new("/bin/sh")
.args(["-c", &stored_command])
.current_dir(f.root.path())
.output()
.await?;
assert!(stored_execution.status.success());
assert_eq!(stored_execution.stdout, b"reviewed correction\n");
let output_path = f.root.path().join("compiled-command.stdout");
fs::write(&output_path, &stored_execution.stdout)?;
assert_eq!(fs::read(&output_path)?, b"reviewed correction\n");
evidence(
"agent-learning-exact-compiled-execution",
&json!({"compiledPath":compiled_path,"storedCommand":stored_command,"argv":["/bin/sh","-c",stored_command],"exit":stored_execution.status.code(),"stdout":String::from_utf8(stored_execution.stdout)?,"stderr":String::from_utf8(stored_execution.stderr)?,"savedOutput":String::from_utf8(fs::read(output_path)?)?}),
)?;
let exported = call(
&client,
"agent_correction_export_kg",
Expand Down
Loading