Repository navigation
Graph data-model integrity: unresolved-reference diagnostics, deployment history, tag validity intervals #232
Description
Part of #168 (gap analysis: data-model integrity).
Problems (from the #168 gap analysis)
- Unresolved-reference diagnostics — the indexer
MERGEs missing occurrences instead of flagging dangling cross-record references; Supply-chain graph: define file-backed artifact discovery and lineage requirements #168 requires actionable diagnostics rather than silently creating an incomplete graph. - Deployment history —
RUNSis keyed only by (deployment, occurrence), so deployment-state changes can overwrite history; Supply-chain graph: define file-backed artifact discovery and lineage requirements #168 requires preserving history (likePOINTED_TO/REFERS_TO). - Tag validity intervals —
POINTED_TOstoresobservedAtbut no derivable validity interval.
Acceptance criteria
- Indexer emits diagnostics for unresolved references (opt-in strict mode acceptable).
- Deployment events are append-only / history-preserving.
- Tag→digest relationships expose a validity interval when derivable.
- Tests + docs updated.
Activity
toddysm commentedon Oct 28, 2026
Approved scope and start checkpoint
The requester approved this issue and the concrete three-part delivery scope on 2026-10-28. Planning format: existing issue-backed requirements plus the scope approved in conversation; design source: #232 and the existing graph architecture. No expanded feature scope is introduced.
Required implementation/documentation child: #250 (native sub-issue). Deliverables: actionable unresolved-reference diagnostics with opt-in strict CLI/service behavior; append-only, idempotent deployment history; evidence-derived tag intervals with explicit ambiguity; unit/integration tests, read-only graph CI, architecture and user instructions.
Testing mode: hosted. Normal Actions and Copilot review authorized. The user approved three PRs (start inventory, implementation, close-out), fix-SHA review replies before resolution, merges only when checks/reviews pass, branch cleanup, temporary session worktrees, and updating the original main after completion. Existing automatic dashboard image publishing/event recording may run on code merge; no manual deployment or registry fixture tests are planned.
Instance:
25e59c6f-a570-4253-aa3b-430d640485e0. Branch:chore/graph-integrity-start-25e59c6f. Owned worktree: session-localfiles/graph-integrity-worktree; exact path recorded in the local ownership claim. Base3eb0644524804085f4c8cf049967374dbe932dc2; clean tracked tree, no commits/unpushed work yet. Tracking remains issues-only.The work-status and source-documentation skill packages are unavailable in this environment; checkpoints are recorded explicitly here, and existing repository docstring conventions will be followed for changed/new declarations. Next: move the inventory row to In progress through the first reviewed PR before source implementation.
toddysm commentedon Oct 28, 2026
Inventory-start merged checkpoint
Start PR #251 merged after required CodeQL passed and Copilot recommended approval with no findings. Tested/pushed source
99ea2a4084a08c58b8cc81f8bfbed3873ec474a7. The graph-integrity row is now In progress on main; implementation child #250 remains open.Instance
25e59c6f-a570-4253-aa3b-430d640485e0, branchchore/graph-integrity-start-25e59c6f, owned session graph-integrity worktree clean and fully pushed. This is the merged checkpoint before removing the start branch and reusing only this owned worktree for the implementation branch. Testing mode: hosted; normal Actions and Copilot review. Next: implement #250 with source/tests/docs and dedicated read-only CI.toddysm commentedon Oct 28, 2026
Parent checkpoint: implementation in review
Start inventory PR #251 is merged. Native child #250 is in review via #252 at tested/pushed SHA
25b68e6c2caea50ece38f59299708c88619d6e9b. Instance25e59c6f-a570-4253-aa3b-430d640485e0, branchfeature/graph-integrity/250-25e59c6f, owned session worktree clean and fully pushed.Testing mode: hosted. All 117 local real-engine graph/HTTP tests and eight-file type diagnostics pass; schema/shell/Helm/documentation checks and baseline-aware lint are clean for this change. Hosted graph/CodeQL and reviews are pending. CI-fix attempts: 0/3.
This parent remains open until the implementation child and required documentation are complete, the separately authorized close-out inventory PR has merged, and the final completion gate is reconciled. No manual deployment or registry fixture work is planned.
toddysm commentedon Oct 28, 2026
Parent checkpoint: review corrections pushed
Implementation PR #252 is at
b226351304bdcf9f489d3fc2b984a85614b31344onfeature/graph-integrity/250-25e59c6f, instance25e59c6f-a570-4253-aa3b-430d640485e0, owned session worktree clean and fully pushed. Hosted testing remains selected.All initial review findings are fixed, individually replied with the appropriate fix SHA and resolved. Current-head local evidence:123 real-engine graph/HTTP tests passed; eight production files type-clean. Prior graph/CodeQL runs passed; fresh checks and Copilot review are pending. CI-fix failures0/3.
The approved completion sequence remains implementation child #250, then the third reviewed inventory close-out PR, and only then closure of this parent. No manual deployment/registry fixture actions have been taken.
toddysm commentedon Oct 28, 2026
Parent checkpoint: final validation contract hardened
PR #252 is at
ce0facce67ccbdf81e91dacc03e57737abf5194c; instance25e59c6f-a570-4253-aa3b-430d640485e0, branchfeature/graph-integrity/250-25e59c6f, owned session worktree clean/fully pushed. Testing mode: hosted. Current local evidence:132 real-engine tests and10-file type checks pass. No runtime manifests changed.All inline review findings are resolved after SHA replies. The remaining review-summary concern was reproduced as an optional jsonschema format-checker dependency gap and fixed by sharing the exact timestamp parser between schema and query paths. Malformed inputs now fail before indexing, not at query time. Fresh CI and review are pending; no merge/bypass attempted. Parent close-out remains gated on child #250 and the third reviewed inventory PR.
toddysm commentedon Oct 28, 2026
Implementation merged; close-out pending
PR #252 merged as
1415ccdf57ba560728c7820fb3a3258d1156f56e; required native child #250 is closed and includes completed user/architecture documentation. Tested sourcef2b2478617b7302cc2544eabca8d86306409c46bpassed146 hosted/local tests, ten-file types, required CodeQL and exact-head Copilot approval recommendation with no active findings.Evidence: https://github.com/toddysm/cssc-framework/actions/runs/40749957490. Full source and docs are merged; all feedback has SHA replies/dispositions. The normal authorized dashboard publishing/graph-event workflows may now run; no manual deployment or fixture tests were dispatched.
Checkpoint before branch cleanup: instance
25e59c6f-a570-4253-aa3b-430d640485e0, branchfeature/graph-integrity/250-25e59c6f, owned session worktree clean/fully pushed; fetched main exactly matches the tested source tree. Testing mode: hosted.This parent remains open until the third reviewed inventory close-out PR merges and completion is rechecked. Next: remove the merged implementation branch, release its child claim, and move this capability to Implemented through that separate docs PR.
toddysm commentedon Oct 28, 2026
Close-out checkpoint: implementation cleanup complete
The implementation branch was removed locally/remotely after its merged checkpoint, and child #250 ownership was released. The only required native child is closed and its architecture/user documentation is complete.
Instance
25e59c6f-a570-4253-aa3b-430d640485e0now ownschore/graph-integrity-close-out-25e59c6fin the same session-owned worktree, reused only after the implementation merged. Base1415ccdf57ba560728c7820fb3a3258d1156f56e; clean tracked state and no close-out commits yet. Testing mode: hosted, with normal CodeQL and Copilot review.Next: move the exact graph-integrity inventory row to Implemented with architecture/user links and2026-10 landing, open the authorized third PR, review/merge it, verify completion again, close this parent and clean the final branch/worktree. Existing post-merge dashboard publishing is running automatically; no manual deployment or fixture run was dispatched.
toddysm commentedon Oct 28, 2026
Close-out checkpoint: In review
Third authorized PR: #253. Tested/pushed source
ff5b7087e039a9f8f230bb1bd1b4561826b53142, branchchore/graph-integrity-close-out-25e59c6f, instance25e59c6f-a570-4253-aa3b-430d640485e0, owned session worktree clean and fully pushed. Testing mode: hosted.Only docs/project-state.md changed. The graph-integrity capability appears once in Implemented with its real landing month and classified architecture/user links; four relative documentation links resolve and whitespace/self-review checks pass. Child #250 is closed with source/docs merged via #252 and146-test hosted evidence. Required CodeQL and Copilot review are pending for this documentation-only PR.
This parent remains open until #253 merges and the completion gate is reconciled. Implementation branch cleanup and child claim release are complete. No new manual deployment/registry fixture actions.
toddysm commentedon Oct 28, 2026
Tracking reconciliation before the inventory close-out merge: GitHub auto-closed this parent when start PR #251 merged because its body contained a negated closing-keyword sentence. GitHub interprets the closing phrase even when preceded by “does not.” The start PR body has been corrected to remove the unintended auto-closing reference, and this parent is reopened until #253 merges and completion is checked. This repairs a workflow error from this run; it is not a scope change. Implementation child #250 remains correctly completed through #252.
toddysm commentedon Oct 28, 2026
Merged close-out checkpoint: completion gate satisfied
Final inventory PR #253 merged as
ed648963c5b61b9412ef2926d334fbb3bf7a3c6d, after required CodeQL and fresh Copilot approval recommendation/no active issues. Tested/pushed close-out sourceff5b7087e039a9f8f230bb1bd1b4561826b53142; local links/row/self-review checks passed. Parent tracking was reconciled and reopened before this merge; the old start-PR negated auto-closing reference has been removed.Fresh reconciliation confirms native child #250 is closed, source/tests/architecture/user docs are merged, and the graph-integrity row is now Implemented on main with the real landing month and classified documentation. No required child is blocked/deferred/failed. Main matches the tested close-out tree.
Implementation PR #252 merged as
1415ccdf57ba560728c7820fb3a3258d1156f56e; tested sourcef2b2478617b7302cc2544eabca8d86306409c46bpassed146 hosted/local tests, ten-file types and required CodeQL. Exact-head Copilot recommended approval. Evidence: https://github.com/toddysm/cssc-framework/actions/runs/40749957490. All inline feedback has fix-SHA replies before resolution; summary findings have explicit dispositions.Merged checkpoint before cleanup: instance
25e59c6f-a570-4253-aa3b-430d640485e0, branchchore/graph-integrity-close-out-25e59c6f, owned session graph-integrity worktree clean and fully pushed atff5b7087e039a9f8f230bb1bd1b4561826b53142. Testing mode: hosted, issues-only tracking.All parent completion prerequisites are now satisfied in the correct order. Next: explicitly mark this issue completed, remove the verified merged branch/worktree, release ownership, and fast-forward the original main checkout. No manual deployment or registry fixture work was performed.
toddysm commentedon Oct 28, 2026
Completed checkpoint and cleanup
State: Done. Parent #232 and its required native implementation/documentation child #250 are closed. The capability inventory is Implemented with architecture/user links and2026-10 landing.
Authorized PR sequence:
eda32541b99f6d7a7f2dea42e1245bf5aea2e127).1415ccdf57ba560728c7820fb3a3258d1156f56e).ed648963c5b61b9412ef2926d334fbb3bf7a3c6d).Final tested implementation source
f2b2478617b7302cc2544eabca8d86306409c46bpassed 146 hosted and local graph/HTTP tests, all12 schema/example files, ten production-file type checks, workflow/shell/Helm/docs checks, baseline-aware lint and final self-review. Hosted evidence: https://github.com/toddysm/cssc-framework/actions/runs/40749957490. All inline review findings received fix-SHA replies before resolution; summary concerns have explicit fixes/dispositions. Copilot recommended approval at both final source heads; required CodeQL passed without bypasses.Normal post-merge automation also passed: all four dashboard images built/published (https://github.com/toddysm/cssc-framework/actions/runs/40750502702), graph-event collection succeeded (https://github.com/toddysm/cssc-framework/actions/runs/40751243756), and final-main CodeQL succeeded (https://github.com/toddysm/cssc-framework/actions/runs/40751488188). No manual deployment or registry fixture workflow was dispatched.
Tracking reconciliation is complete: the unintended negated closing-keyword reference in start PR #251 was removed, this parent was reopened before the final close-out merge, completion was verified after that merge, and only then was the parent explicitly closed. The ordering error remains transparently recorded in issue history rather than hidden.
All task branches were deleted locally/remotely after merged-state checkpoints; the temporary worktree, isolated dependencies, ownership claims and temporary tooling/watch logs are removed. Original checkout is clean on main at
ed648963c5b61b9412ef2926d334fbb3bf7a3c6d, matching origin/main, with only local main and the original checkout remaining. No unpushed/unmerged task work or local helper processes remain.Testing mode: hosted. Tracking: issues-only. Instance:
25e59c6f-a570-4253-aa3b-430d640485e0. Existing derived local graph databases need the documented one-time index --rebuild; source files are unchanged. Next action for this feature: none.