Repository navigation
Graph integrity: diagnostics, deployment history and observed tag intervals #250
Description
Implementation work item for #232, authorized by the requester on 2026-10-28.
Acceptance criteria
- Emit file/location-addressed unresolved-occurrence reference diagnostics after considering the complete input set, independent of file order; preserve permissive indexing with visible warnings, and add opt-in strict behavior through CLI and graph-service configuration/readiness.
- Preserve distinct deployment observations and their evidence without overwriting earlier events; reindexing the same input stays idempotent. Shared queries/HTTP surfaces expose that history.
- Expose evidence-derived tag validity bounds through shared queries, CLI and HTTP responses. Normalize timestamp ordering and leave ambiguous/unknown bounds explicit instead of inventing certainty.
- Preserve existing default behavior and response fields; add unit/integration tests and dedicated read-only hosted graph CI.
- Update architecture and user instructions with exact semantics, success/error examples, and rebuild guidance as needed.
Testing mode: hosted, with normal GitHub Actions and Copilot review. No manual deployment or registry fixture execution. The user authorized existing automatic dashboard publication/graph-event workflows on merge.
Delivery: reviewed start-inventory PR, one implementation PR closing this child, then a separate close-out inventory PR before #232 closes.
Activity
toddysm commentedon Oct 28, 2026
Pending implementation checkpoint
Owned by instance
25e59c6f-a570-4253-aa3b-430d640485e0, coordinated under parent #232. Testing mode: hosted, with Copilot review. Source implementation waits for the reviewed start-inventory PR to merge. No implementation branch/commits yet; the start-inventory branch ischore/graph-integrity-start-25e59c6fin the session-owned graph-integrity worktree. No active external owner was present at claim time.toddysm commentedon Oct 28, 2026
Implementation checkpoint: In progress
The start inventory PR #251 merged as
eda32541b99f6d7a7f2dea42e1245bf5aea2e127. Its branch was removed locally/remotely after the merged checkpoint. This child is now claimed by instance25e59c6f-a570-4253-aa3b-430d640485e0onfeature/graph-integrity/250-25e59c6fin the same owned session worktree. Baseeda3254; clean tracked state, no implementation commits yet. Testing mode: hosted.The native LadybugDB dependency is now available in the isolated local environment: all 87 existing graph-library/service tests passed without skips. Next: reproduce the three defects in new tests, implement shared diagnostics/history/interval logic, wire CLI/HTTP/config/chart/docs, and add read-only hosted graph checks. Default indexing stays permissive with visible reference warnings; strict failures must occur before index writes. Existing schema-version migration is out of scope (#233), so any additive deployment-edge property will include explicit rebuild guidance.
toddysm commentedon Oct 28, 2026
Implementation checkpoint: In review
PR: #252 (Closes #250; parent #232 stays open).
Instance
25e59c6f-a570-4253-aa3b-430d640485e0; branchfeature/graph-integrity/250-25e59c6f; owned session graph-integrity worktree. Tested/pushed SHA25b68e6c2caea50ece38f59299708c88619d6e9b; clean tracked state and no unpushed work. Testing mode: hosted, with normal Actions and Copilot review.At this exact head: 117 real-engine graph-library/HTTP tests pass, 8 changed production files type-check, new workflow schema and three shell blocks are clean, Helm operator config renders correctly, seven doc links resolve, and no new Ruff diagnostics versus main. One unrelated pre-existing Starlette deprecation warning remains. Editor-specific tooling and source-documentation templates are unavailable; repository conventions and CLI diagnostics were used and disclosed.
The regression suite reproduced deployment overwrite before the fix. Strict reference preflight preserves an existing database on failure; reference declarations are input-set/repository-scoped; deployment identity includes observation evidence; UTC intervals handle repeats, reversions and simultaneous conflicting targets without arbitrary resolution. No dependency manifests or chart defaults changed.
Self-review: no remaining findings at the tested head. Next: settle hosted graph/CodeQL and Copilot/Codex review; fix findings with SHA replies before resolution, merge only when green, then checkpoint before branch cleanup. CI-fix attempts: 0/3.
toddysm commentedon Oct 28, 2026
Review-fix checkpoint: exact timestamp evidence
PR #252 at tested/pushed SHA
7f0b936f51365140c83305f6fb290470fe831e75, branchfeature/graph-integrity/250-25e59c6f, instance25e59c6f-a570-4253-aa3b-430d640485e0; owned session worktree clean and fully pushed. Testing mode: hosted.Initial hosted graph/CodeQL passed (117 tests). A focused runtime check and Codex review identified a schema/parser mismatch: lowercase UTC markers were rejected and sub-microsecond fractions truncated. The shared parser now preserves exact RFC 3339 fractions and leap-second ordering without narrowing validation. Four additional regressions bring the local suite to 121 passed. The finding received a threaded fix-SHA reply before resolution. Fresh review/current-head hosted checks are pending. CI-fix failures remain 0/3.
Next: require settled reviews and green current-head graph/CodeQL before merge; keep parent #232 open until the separate close-out PR merges.
toddysm commentedon Oct 28, 2026
Review checkpoint: all initial findings addressed
PR #252 at tested/pushed SHA
b226351304bdcf9f489d3fc2b984a85614b31344; branchfeature/graph-integrity/250-25e59c6f, instance25e59c6f-a570-4253-aa3b-430d640485e0, owned session worktree clean and fully pushed. Testing mode: hosted.All five initial Codex/Copilot threads have individual fix-SHA replies and were resolved afterward. Corrections preserve exact schema-valid RFC3339 instants, retain full deployment source evidence, and run a read-only legacy-schema guard on query opens with clear rebuild guidance. Local suite is now 123 passed, with all eight production files type-clean. Both prior hosted source heads passed graph and CodeQL; fresh current-head review/CI is pending. No failing hosted CI-fix attempts (0/3).
Next: require current-head green hosted checks and settled review; merge child implementation, then perform the separately authorized inventory close-out before #232 closes.
toddysm commentedon Oct 28, 2026
Review checkpoint: actionable compatibility/startup errors
Current tested/pushed SHA
d52d45fc3167ccf4d7b08f2e72fdb59dcf89bc48, PR #252, instance25e59c6f-a570-4253-aa3b-430d640485e0, branchfeature/graph-integrity/250-25e59c6f; owned session worktree clean/fully pushed. Testing mode: hosted.The confirmed latest-head review workflow completed and found two additional error-surface gaps: the CLI context-entry compatibility exception and count-only startup logging. Both are fixed with execution/log-capture regressions. The inline finding has a fix-SHA reply and is resolved; the summary-only concern received its own fix-SHA PR reply. 124 local graph/HTTP tests and all 8 production-file type checks pass at the exact head. Fresh hosted graph/CodeQL and current-head Copilot review are pending; no merge or bypass attempted. Hosted CI-fix failures remain0/3.
toddysm commentedon Oct 28, 2026
Review checkpoint: timestamp validation dependency gap fixed
PR #252 at tested/pushed SHA
ce0facce67ccbdf81e91dacc03e57737abf5194c, branchfeature/graph-integrity/250-25e59c6f, instance25e59c6f-a570-4253-aa3b-430d640485e0, owned session worktree clean and fully pushed. Testing mode: hosted.Latest review had no unresolved inline findings, but raised a summary concern about malformed timestamps reaching queries. Runtime evidence showed jsonschema had no registered date-time checker without optional extras. The exact parser is now shared by schema validation and queries and explicitly registered; no runtime dependency manifest changes. Eight new tests verify invalid timestamps fail before writes/readiness and all supported valid spellings remain accepted. 132 local graph/HTTP tests and 10 production-file type checks pass at the exact head. The summary concern received a fix-SHA PR reply. Current-head CI/review pending; all prior hosted CI runs passed (failure attempts0/3).
Parent #232 remains open until implementation and the separate inventory close-out merge.
toddysm commentedon Oct 28, 2026
Review checkpoint: strict offset bounds
PR #252 at tested/pushed SHA
65fa4008e94e33b19d23c6a71e582ca90f0be4db, instance25e59c6f-a570-4253-aa3b-430d640485e0, branchfeature/graph-integrity/250-25e59c6f, owned session worktree clean and fully pushed. Testing mode: hosted.Latest review found datetime normalizes malformed offset minutes such as +00:60. This was reproduced, fixed with explicit RFC3339 offset-component bounds, and covered by invalid-offset/schema/CLI tests plus valid boundary cases. The thread received a fix-SHA reply before resolution. 140 local graph/HTTP tests and 10 production-file type checks pass at the exact head. Fresh hosted review/CI is pending. All earlier hosted CI passed; no CI failure attempts0/3. No merge or protection override.
toddysm commentedon Oct 28, 2026
Review checkpoint: leap-marker evidence boundary
PR #252 at tested/pushed SHA
41810b2cce7f5e86079a968031d5ccc4a165b7bc, instance25e59c6f-a570-4253-aa3b-430d640485e0, branchfeature/graph-integrity/250-25e59c6f, owned session worktree clean/fully pushed. Testing mode: hosted.Latest review had no unresolved inline findings, but a summary requested assessment of leap markers. Structural validation now requires the UTC-normalized end of a month; tests reject impossible placement and use an actual historical leap/offset equivalent for positive cases. The docs explicitly distinguish structure validation from external announcement/event truth verification. The summary received a fix-SHA PR reply. 145 local tests and 10-file type checks pass at the exact head. Fresh hosted checks/review pending; prior hosted runs all passed, CI-fix failures0/3.
toddysm commentedon Oct 28, 2026
Review checkpoint: history-query scalability assessed
PR #252 at tested/pushed SHA
f2b2478617b7302cc2544eabca8d86306409c46b, instance25e59c6f-a570-4253-aa3b-430d640485e0, branchfeature/graph-integrity/250-25e59c6f; owned session worktree clean/fully pushed. Testing mode: hosted.The latest review had no unresolved inline findings and asked for assessment of per-occurrence queries under the read guard. History retrieval is now a single parameterized projection after seed resolution; a10-occurrence real-engine regression measures2 database calls. The safety lock remains, and the guide states that full-history cost still scales with returned evidence rather than claiming pagination/streaming. All146 local tests and10-file type checks pass. Summary disposition posted with fix SHA; fresh hosted review/CI pending. All prior hosted CI passed; no failure attempts0/3.
toddysm commentedon Oct 28, 2026
Merged checkpoint: implementation complete
PR #252 merged as
1415ccdf57ba560728c7820fb3a3258d1156f56e. Tested/pushed sourcef2b2478617b7302cc2544eabca8d86306409c46b.All146 hosted graph/HTTP tests passed without skips, and all12 schema/example files validated: https://github.com/toddysm/cssc-framework/actions/runs/40749957490. CodeQL passed; exact-head Copilot review recommended approval with no active issues. All inline findings have individual fix-SHA replies before resolution; summary concerns have evidence-backed dispositions. Local146 tests, ten-file types, syntax/workflow/shell/Helm/docs checks, baseline-aware lint and final self-review passed. No runtime manifests/chart defaults changed.
Delivered: input-set reference diagnostics with strict CLI/service preflight, preserved full-source deployment observations and batched queries, exact UTC tag intervals with explicit ambiguity, shared always-on timestamp validation, legacy DB rebuild guidance, user/architecture docs and dedicated read-only graph CI.
Merged-state checkpoint before cleanup: instance
25e59c6f-a570-4253-aa3b-430d640485e0, branchfeature/graph-integrity/250-25e59c6f, owned session graph-integrity worktree clean and fully pushed at the tested source. The fetched main tree matches the tested implementation tree. Testing mode: hosted. No CI failure attempts0/3.Next: remove the implementation branch after this checkpoint, reuse only this owned worktree for the authorized third close-out PR, and keep parent #232 open until its Implemented inventory row merges.