Repository navigation
Support tag references when listing referrers - #68
Conversation
Reuse the manifest HEAD operation, preserve digest passthrough, and report lookup failures before querying referrers or writing output. Cover flag combinations and library wiring, update CLI documentation, and add hosted Python test validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the changes adding tag support to regshape referrer list.
No open issues 🎉
What changed in this PR
Adds tag support to regshape referrer list, addressing #46 by reusing the existing manifest library to resolve tags before querying referrers.
Changes:
- Resolves explicit and default (
latest) tags while preserving digest passthrough and existing output options. - Adds tests for resolution, failure handling, and CLI-to-library integration; updates help and specifications.
- Adds a Python 3.10–3.12 test workflow and documents local test commands.
| File | Description |
|---|---|
src/regshape/tests/test_referrer_cli.py |
Tests tag resolution, digest passthrough, errors, and output options. |
src/regshape/cli/referrer.py |
Resolves tags with manifest HEAD requests and handles lookup failures. |
specs/cli/referrer.md |
Documents accepted references, resolution behavior, errors, and examples. |
CONTRIBUTING.md |
Documents test setup and execution. |
.github/workflows/tests.yml |
Runs pytest on Python 3.10, 3.11, and 3.12. |
Review effort: Balanced
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Integrate the reviewed referrer feature before validating and merging tag pagination. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add list_tags_all and opt-in tag list --all with OCI pagination semantics, safe continuation and authentication redirects, explicit malformed-response errors, and a ten-consecutive-empty-linked-page safety limit. Preserve single-page behavior and avoid partial output. Includes merged referrer support from #68. The combined tree passed 1300 tests per supported Python version, CodeQL, scoped type checks, and refreshed Copilot/Codex reviews. Closes #69 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Summary
Allow
regshape referrer list -i registry/repo:tagto resolve the tag with a manifest HEAD request before querying referrers.latest.--all,--artifact-type,--json, and--outputbehavior.Current validation
Testing mode: hosted. Tested/pushed/reviewed head:
e5d1adad3be0efb4bd1dc32cd17135f4e7634507.Integrated main
6d2c188b07e6211263b6ba3518eeee97bd2bae20with a normal merge commit. The baseline repairs and shared test workflow from #71 are now included; history was not rewritten and the feature scope is unchanged.PYTHONDONTWRITEBYTECODE=1 python3 -B -m pytest -q -p no:cacheprovider— 1071 passed on Python 3.12.4.Tests use mocked registry/network responses, not a live registry. Release automation is unchanged. Merged with owner authorization as
5fdd598a3233d5cb53b4380c22f104e4a91bf439; the signed merge tree exactly matches the tested/reviewed head. Issue #46 is closed. No release or branch/worktree cleanup was performed.Closes #46