Repository navigation
Fix baseline catalog and authentication tests - #71
Merged
Merged
Conversation
Make catalog pagination mocks update last_response, preserve existing result/cursor/error assertions, and add real-client contract cases. Verify the intended resource-to-v2 authentication probe sequence with no credential exchange. Add hosted test validation without changing production behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 29, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the test, documentation, and CI updates.
No open issues 🎉
What changed in this PR
Repairs five baseline test failures blocking validation of #68 and #70, without changing production library, CLI, or release behavior.
Changes:
- Align catalog mocks with the
last_responsecontract and add real-client pagination coverage in both transport modes. - Verify authentication challenge discovery through
/v2/, followed by failure without credential exchange. - Add hosted tests on Python 3.10–3.12 and document local test commands.
| File | Description |
|---|---|
src/regshape/tests/test_transport_client.py |
Corrects the expected authentication request sequence and checks that no credential exchange occurs. |
src/regshape/tests/test_catalog_operations.py |
Repairs pagination fixtures and adds real-client success and second-page failure coverage. |
CONTRIBUTING.md |
Documents test installation, execution, and mocked-network scope. |
.github/workflows/tests.yml |
Runs pytest across three Python versions for pull requests and pushes to main. |
Review effort: Balanced
This was referenced Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repair the five pre-existing test failures blocking validation of #68 and #70. This is a test/infrastructure-only change: no production library, command-line interface, or package behavior is modified.
client.last_response, matching the real client contract. Preserve the original result, page-count, cursor, and error-propagation assertions./v2/challenge probe. Still require the authentication error and verify that no credential exchange occurs.Validation
Testing mode: hosted. Head:
51a8b97cc1587265414862ae3c6af2c8d02af62f.Before the fix, the affected baseline classes reproduced 5 failures and 6 passes on unchanged main
024c15bc7da136448a3856de59fe30deea0a49a5.After the fix on Python 3.12.4:
PYTHONDONTWRITEBYTECODE=1 python3 -B -m pytest -q -p no:cacheprovider: 1047 passed.--implicit-optional); imported-module diagnostics are suppressed.All registry/network responses in these checks are mocked; this is not live-registry validation.
Hosted run 40948711011 passed on the current head: 1047 tests passed on each of Python 3.10, 3.11, and 3.12. CodeQL checks passed. Copilot review completed for this commit, recommends approval, and has no findings or unresolved threads. The pull request remains open and unmerged for owner review.
Integration
This pull request is based directly on main, not stacked on either feature branch. It does not close the feature issues. Once merged with owner authorization, update #68 and #70 from main and rerun their checks. No merge is authorized as part of this task.