Repository navigation
refactor: remove duplicated and dead code without changing behavior - #1021
Merged
Merged
Conversation
generate.ts only ever passes operationMapper, so the setOperationId duplicate check, its operationId spread and the jsonQuery content branch never ran. The mediaExamples key is still stripped from query parameter schemas. Regenerated openapi.json is byte-identical.
Nothing imports it: searchResultResponseSchema inlines the list field and search/index.ts never re-exported it, so it was never reachable from the package entry. OpenAPI and built types are byte-identical.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…elper addManager, addAllowedUser, removeManager and removeAllowedUser were four copies of one request that differed only in the URL segment and HTTP method. addMember and removeMember now call accountRequest with memberPath, and changeMemberRole goes through them. Same URLs, methods and call order; memberPath has its own spec.
showActivityHistoryResponseSchema was a byte-identical copy of episodeActivityHistoryResponseSchema. The show history routes now use the episode schema, and the public ShowActivityHistoryResponse type keeps its name. OpenAPI output is byte-identical.
hiddenRemoveResponseSchema was byte-identical to the sync history remove response and was never exported. The three hidden remove routes now use the sync schema. OpenAPI output and route types are byte-identical.
Four toggle schemas were the same watching/watched/rated/collected object and three were the same rated-only object. Each shape is now declared once and the exported names alias it. OpenAPI output and built types are byte-identical.
The added and deleted counts in the ratings sync responses re-declared the movies/shows/seasons/episodes object that mediaMutationCountsSchema already provides with the same key order. OpenAPI output and built types are byte-identical.
tmdb, imdb, letterboxd and both mal blocks each re-declared externalRatingsResponseSchema extended with the same votes field. They now use one internal externalVotedRatingsResponseSchema. OpenAPI output and route types are byte-identical.
The list add/remove and sync favorites add/remove responses each
re-declared the same { updated_at, item_count } list object. They now
use one internal listSummaryResponseSchema. OpenAPI output and route
types are byte-identical.
…ramFactory trendingSearchTypeParamFactory had the same body as searchTypeParamFactory with the type list hardcoded. The trending route now passes the list to searchTypeParamFactory, which infers the same tuple. OpenAPI output and the search route types are byte-identical.
…itor RequestEditor re-implemented the "JSON body expected but empty" rule inline. It now calls the existing helper, which runs the same expression, so the rule lives in one place.
restore, setValue, setServer and setMainServer each repeated the same buildEndpointUrl call against the current server and values. They now call refreshRequestUrl, which reads the same state.
GuideReader imported contents.md a second time with ?raw and aliased GUIDE_SOURCES to a local name, although the GUIDE_SOURCES glob already holds the same raw text under "contents" (GUIDES.ts reads it the same way).
.request-line > label and .body-editor label carried the same five declarations. They now share one rule. No other rule in the component targets those labels, so the cascade is unchanged.
The app-limit and locked create tiles each inlined the same lock SVG. Both now render a lockIcon snippet with identical markup.
fetchAccounts only wrapped listAccounts().catch(() => []) in a one-field DeveloperAccountState object that its single caller unwrapped again. refreshAccounts now runs the same expression itself.
parseRequestBody and parseResponses repeated the "prefer a JSON content type" lookup, and the response example and required example repeated the same string-or-JSON formatting. Two file-local helpers now hold each rule. Parsing static/openapi.json gives a byte-identical catalog (332 endpoints).
… file Route tables in shows, movies, sync, lists, calendars, comments, scrobble and the users subroutes repeated the same .merge() chains (and scrobble the same unions) at up to 15 routes each. Each repeated chain is now one file-local, non-exported const built with the same calls in the same order. OpenAPI output and built types are byte-identical after every file.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 67d66cc1bd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
vladjerca
force-pushed
the
refactor/nado
branch
from
October 17, 2026 22:04
67d66cc to
ff158e8
Compare
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behavior-preserving cleanup pass: removes duplicated and dead code across the API package, the OpenAPI generator and the developer portal. 18 commits, one finding each, so any single commit can be dropped. 47 files, +437 / -752.
What changed
API package (10 commits)
searchListResponseSchema(never imported, not reachable from the package entry).ShowActivityHistoryResponsetype keeps its name), hidden removals usehistoryRemoveResponseSchema, sync ratings usemediaMutationCountsSchema.watching/watched/rated/collectedobjects and the threerated-only objects are declared once and the exported names alias them.externalVotedRatingsResponseSchemareplaces five copies ofexternalRatingsResponseSchema.extend({ votes }), and one internallistSummaryResponseSchemareplaces four{ updated_at, item_count }blocks.searchTypeParamFactory, sotrendingSearchTypeParamFactoryis gone (jsr.mdupdated)..merge()chain (up to 15 sites each) is now one file-local, non-exported const built with the same calls in the same order.OpenAPI generator (1 commit)
setOperationIdandjsonQueryoptions;generate.tsnever passes them.Developer portal (7 commits)
addManager/addAllowedUser/removeManager/removeAllowedUsercollapse intoaddMember/removeMemberover a newmemberPathhelper (with spec).fetchAccounts+DeveloperAccountStateinlined into their single caller.RequestEditoruseshasMissingExpectedJsonBodyinstead of an inline copy, and its two visually hidden label rules share one selector.DeveloperApprebuilds the request URL through one local function,GuideReaderreadscontents.mdfromGUIDE_SOURCESinstead of a second import, the create-tile lock icon is one snippet, andparseOpenApiDocumentholds the content-type pick and example formatting in one place each.How behavior was checked
openapi.json: byte-identical to master after every API commit, and the portal'sstatic/openapi.jsonis identical too..d.tstypes (build:types): byte-identical after every commit, except two internal files where an unusedzimport was dropped, soz.ZodXnow readsimport("zod").ZodX(same type, and no other declaration imports those files). Two variants that changed public declaration text were reverted.deno doc src/index.tslists the same 429 symbols as master, all documented.deno task publish:checksucceeds.static/openapi.jsongives a byte-identical catalog (332 endpoints).Gates
deno task test16 passed;openapi:validateok; openapi tests 7 passed;publish:checkSuccessdeno fmt --checkok, prettier ok, svelte-check 571 files 0 errors, vitest 71 files / 367 tests (base 70 / 364; +3 formemberPath), build okdeno fmt --check(34 files) anddeno lintfail on master too and are not in CI. Lint is unchanged with built types present; without themno-slow-typesgoes from 523 to 545, because exported routes now reference the hoisted file-local consts. Publishing uses the built types, so JSR is unaffected (publish:checkpasses).Not verified
Flagged, deliberately NOT changed
LikesResponseinmodels/index.tsis typed fromepisodeResponseSchema; looks like the wrong target, but it is a public type.traktApiFactoryreassignscancellationIdon the first request, so every later request on that client shares it.favoritedMovies/ShowsResponseSchemaequal the listed-item schemas except for key order; merging would reorder OpenAPI and parsed output.ratedSeasonResponseSchema.idsuses the episode ids schema.createDeviceTokenPollerdoes not return after rejecting on expiry, so one more token request fires.@ts-rest/open-apiis unused inprojects/openapi/deno.json; removing it changesdeno.lock.--ni-*/ sizing tokens in the portal's copied scale files.scripts/build-types.tskeeps a second copy of the module doc frommod.js(publish tooling).enums/*Schema.ts,movie/showHotResponseSchema.ts) andshowStatsResponseSchema: inlining would move public declarations.accountRequeststatus messages that overlapdeveloperErrorMessage: security and message behavior.