refactor: remove duplicated and dead code without changing behavior

.agents/rules/jsr.md

@@ -43,9 +43,8 @@ annotations - they are load-bearing:
   `UsersRouter = ReturnType<typeof builder.router<...>>` with an
   `as unknown as UsersRouter` cast. Keep the internal route groups
   (`GLOBAL_LEVEL`, `ENTITY_LEVEL`, `syncs`, `plex`) non-exported.
-- The query factories (`extendedQuerySchemaFactory`, `searchTypeParamFactory`,
-  `trendingSearchTypeParamFactory`) have explicit `z.ZodObject<{...}>` returns
-  (avoids TS5088 cyclic).
+- The query factories (`extendedQuerySchemaFactory`, `searchTypeParamFactory`)
+  have explicit `z.ZodObject<{...}>` returns (avoids TS5088 cyclic).
 - `builder` is typed `ReturnType<typeof initContract>` (avoids TS4023).
 
 If a new symbol trips TS7056/TS5088/TS4023 during `build:types`, give it an

projects/api/src/contracts/_internal/response/listAddResponseSchema.ts

@@ -1,3 +1,4 @@
+import { listSummaryResponseSchema } from './listSummaryResponseSchema.ts';
 import { bulkMediaRequestSchema } from '../request/bulkMediaRequestSchema.ts';
 import { z } from '../z.ts';
 import { mediaMutationCountsSchema } from './mediaMutationCountsSchema.ts';
@@ -7,8 +8,5 @@ export const listAddResponseSchema = z.object({
   added: mediaMutationCountsSchema,
   existing: mediaMutationCountsSchema,
   not_found: bulkMediaRequestSchema,
-  list: z.object({
-    updated_at: z.string().datetime(),
-    item_count: z.number().int(),
-  }),
+  list: listSummaryResponseSchema,
 });

projects/api/src/contracts/_internal/response/listRemoveResponseSchema.ts

@@ -1,3 +1,4 @@
+import { listSummaryResponseSchema } from './listSummaryResponseSchema.ts';
 import { bulkMediaRequestSchema } from '../request/bulkMediaRequestSchema.ts';
 import { z } from '../z.ts';
 import { mediaMutationCountsSchema } from './mediaMutationCountsSchema.ts';
@@ -6,8 +7,5 @@ import { mediaMutationCountsSchema } from './mediaMutationCountsSchema.ts';
 export const listRemoveResponseSchema = z.object({
   deleted: mediaMutationCountsSchema,
   not_found: bulkMediaRequestSchema,
-  list: z.object({
-    updated_at: z.string().datetime(),
-    item_count: z.number().int(),
-  }),
+  list: listSummaryResponseSchema,
 });

projects/api/src/contracts/_internal/response/listSummaryResponseSchema.ts

@@ -0,0 +1,7 @@
+import { z } from '../z.ts';
+
+/** Zod schema for the list summary returned after a list item change. */
+export const listSummaryResponseSchema = z.object({
+  updated_at: z.string().datetime(),
+  item_count: z.number().int(),
+});

projects/api/src/contracts/_internal/response/movieRatingsResponseSchema.ts

@@ -1,7 +1,6 @@
-import { z } from '../z.ts';
 import {
   extendedRatingsResponseExample,
-  externalRatingsResponseSchema,
+  externalVotedRatingsResponseSchema,
   ratingsResponseExample,
   ratingsResponseSchema,
 } from './ratingsResponseSchema.ts';
@@ -15,16 +14,12 @@ export const movieRatingsResponseSchema = ratingsResponseSchema.extend({
    * Letterboxd audience rating on a 0-5 scale. Films only.
    * Available if requesting extended `all`.
    */
-  letterboxd: externalRatingsResponseSchema.extend({
-    votes: z.number().int().nullish(),
-  }).nullish(),
+  letterboxd: externalVotedRatingsResponseSchema.nullish(),
   /**
    * MyAnimeList audience rating on a 0-10 scale. Anime only.
    * Available if requesting extended `all`.
    */
-  mal: externalRatingsResponseSchema.extend({
-    votes: z.number().int().nullish(),
-  }).nullish(),
+  mal: externalVotedRatingsResponseSchema.nullish(),
 }).openapi({
   mediaExamples: {
     default: {

projects/api/src/contracts/_internal/response/ratingsResponseSchema.ts

@@ -66,6 +66,12 @@ export const externalRatingsResponseSchema = z.object({
   link: z.string().nullish(),
 });
 
+/** Shared shape for an external rating source that also reports its vote count. */
+export const externalVotedRatingsResponseSchema = externalRatingsResponseSchema
+  .extend({
+    votes: z.number().int().nullish(),
+  });
+
 /** Zod schema for the ratings response. */
 export const ratingsResponseSchema = z.object({
   rating: float(z.number()).nullish(),
@@ -79,15 +85,11 @@ export const ratingsResponseSchema = z.object({
   /**
    * Available if requesting extended `all`.
    */
-  tmdb: externalRatingsResponseSchema.extend({
-    votes: z.number().int().nullish(),
-  }).nullish(),
+  tmdb: externalVotedRatingsResponseSchema.nullish(),
   /**
    * Available if requesting extended `all`.
    */
-  imdb: externalRatingsResponseSchema.extend({
-    votes: z.number().int().nullish(),
-  }).nullish(),
+  imdb: externalVotedRatingsResponseSchema.nullish(),
   /**
    * Available if requesting extended `all`.
    */

projects/api/src/contracts/_internal/response/showRatingsResponseSchema.ts

@@ -1,7 +1,6 @@
-import { z } from '../z.ts';
 import {
   extendedRatingsResponseExample,
-  externalRatingsResponseSchema,
+  externalVotedRatingsResponseSchema,
   ratingsResponseExample,
   ratingsResponseSchema,
 } from './ratingsResponseSchema.ts';
@@ -15,9 +14,7 @@ export const showRatingsResponseSchema = ratingsResponseSchema.extend({
    * MyAnimeList audience rating on a 0-10 scale. Anime only.
    * Available if requesting extended `all`.
    */
-  mal: externalRatingsResponseSchema.extend({
-    votes: z.number().int().nullish(),
-  }).nullish(),
+  mal: externalVotedRatingsResponseSchema.nullish(),
 }).openapi({
   mediaExamples: {
     default: {

projects/api/src/contracts/calendars/index.ts

@@ -15,6 +15,20 @@ const groupQuery = z.object({
   }),
 });
 
+const filteredCalendarQuerySchema = extendedMediaQuerySchema
+  .merge(mediaFilterParamsSchema)
+  .merge(ignoreQuerySchema);
+
+const mediaFeedQuerySchema = extendedMediaQuerySchema
+  .merge(mediaFilterParamsSchema)
+  .merge(z.object({
+    type: z.enum(['movie', 'show']).optional().openapi({
+      description:
+        'Narrow the feed to a single media type. Omit to return both.',
+    }),
+  }))
+  .merge(groupQuery);
+
 const globalCalendarCurationNotice =
   'When `target` is `all`, the global calendar uses automatic quality filters to reduce incorrect or low-quality entries. As a result, it may not include every matching item in the database, even when that item has complete information. An omitted item may appear later after it meets the filter requirements.';
 
@@ -45,9 +59,7 @@ Returns new shows airing their first season during the requested UTC date range.
 ${globalCalendarCurationNotice}`,
     method: 'GET',
     path: '/:target/shows/new/:start_date/:days',
-    query: extendedMediaQuerySchema
-      .merge(mediaFilterParamsSchema)
-      .merge(ignoreQuerySchema),
+    query: filteredCalendarQuerySchema,
     pathParams: calendarRequestParamsSchema,
     responses: {
       200: calendarShowResponseSchema.array(),
@@ -61,9 +73,7 @@ Returns season premieres airing during the requested UTC date range. Use \`targe
 ${globalCalendarCurationNotice}`,
     method: 'GET',
     path: '/:target/shows/premieres/:start_date/:days',
-    query: extendedMediaQuerySchema
-      .merge(mediaFilterParamsSchema)
-      .merge(ignoreQuerySchema),
+    query: filteredCalendarQuerySchema,
     pathParams: calendarRequestParamsSchema,
     responses: {
       200: calendarShowResponseSchema.array(),
@@ -77,9 +87,7 @@ Returns show finales airing during the requested UTC date range. Use \`target\`
 ${globalCalendarCurationNotice}`,
     method: 'GET',
     path: '/:target/shows/finales/:start_date/:days',
-    query: extendedMediaQuerySchema
-      .merge(mediaFilterParamsSchema)
-      .merge(ignoreQuerySchema),
+    query: filteredCalendarQuerySchema,
     pathParams: calendarRequestParamsSchema,
     responses: {
       200: calendarShowResponseSchema.array(),
@@ -93,9 +101,7 @@ Returns movies with a release date during the requested UTC date range. Use \`ta
 ${globalCalendarCurationNotice}`,
     method: 'GET',
     path: '/:target/movies/:start_date/:days',
-    query: extendedMediaQuerySchema
-      .merge(mediaFilterParamsSchema)
-      .merge(ignoreQuerySchema),
+    query: filteredCalendarQuerySchema,
     pathParams: calendarRequestParamsSchema,
     responses: {
       200: calendarMovieResponseSchema.array(),
@@ -109,9 +115,7 @@ Returns all movies with a streaming release date during the requested UTC date r
 ${globalCalendarCurationNotice}`,
     method: 'GET',
     path: '/:target/streaming/:start_date/:days',
-    query: extendedMediaQuerySchema
-      .merge(mediaFilterParamsSchema)
-      .merge(ignoreQuerySchema),
+    query: filteredCalendarQuerySchema,
     pathParams: calendarRequestParamsSchema,
     responses: {
       200: calendarMovieResponseSchema.array(),
@@ -125,9 +129,7 @@ Returns DVD and physical media releases during the requested UTC date range. Use
 ${globalCalendarCurationNotice}`,
     method: 'GET',
     path: '/:target/dvd/:start_date/:days',
-    query: extendedMediaQuerySchema
-      .merge(mediaFilterParamsSchema)
-      .merge(ignoreQuerySchema),
+    query: filteredCalendarQuerySchema,
     pathParams: calendarRequestParamsSchema,
     responses: {
       200: calendarMovieResponseSchema.array(),
@@ -141,15 +143,7 @@ Returns the merged feed of movies and episodes during the requested UTC date ran
 ${globalCalendarCurationNotice}`,
     method: 'GET',
     path: '/:target/media/:start_date/:days',
-    query: extendedMediaQuerySchema
-      .merge(mediaFilterParamsSchema)
-      .merge(z.object({
-        type: z.enum(['movie', 'show']).optional().openapi({
-          description:
-            'Narrow the feed to a single media type. Omit to return both.',
-        }),
-      }))
-      .merge(groupQuery),
+    query: mediaFeedQuerySchema,
     pathParams: calendarRequestParamsSchema,
     responses: {
       200: hotReleaseResponseSchema.array(),
@@ -161,15 +155,7 @@ ${globalCalendarCurationNotice}`,
 Returns the merged feed of upcoming movies and episodes during the requested UTC date range that are trending or highly anticipated, ordered by availability date. This is the global feed only; use \`type\` to narrow to a single media type.`,
     method: 'GET',
     path: '/releases/hot/:start_date/:days',
-    query: extendedMediaQuerySchema
-      .merge(mediaFilterParamsSchema)
-      .merge(z.object({
-        type: z.enum(['movie', 'show']).optional().openapi({
-          description:
-            'Narrow the feed to a single media type. Omit to return both.',
-        }),
-      }))
-      .merge(groupQuery),
+    query: mediaFeedQuerySchema,
     pathParams: calendarRequestParamsSchema.omit({ target: true }),
     responses: {
       200: hotReleaseResponseSchema.array(),

projects/api/src/contracts/comments/index.ts

@@ -32,6 +32,11 @@ const includeRepliesQuerySchema = z.object({
   ),
 });
 
+const commentActivityQuerySchema = extendedProfileQuerySchema
+  .merge(pageQuerySchema)
+  .merge(limitlessQuerySchema)
+  .merge(includeRepliesQuerySchema);
+
 const commentItemResponseSchema = z.union([
   movieResponseSchema,
   showResponseSchema,
@@ -277,10 +282,7 @@ const GLOBAL_LEVEL = builder.router({
     path: '/trending/:comment_type/:type',
     method: 'GET',
     pathParams: commentActivityParamsSchema,
-    query: extendedProfileQuerySchema
-      .merge(pageQuerySchema)
-      .merge(limitlessQuerySchema)
-      .merge(includeRepliesQuerySchema),
+    query: commentActivityQuerySchema,
     responses: {
       200: commentResponseSchema.array(),
     },
@@ -292,10 +294,7 @@ const GLOBAL_LEVEL = builder.router({
     path: '/recent/:comment_type/:type',
     method: 'GET',
     pathParams: commentActivityParamsSchema,
-    query: extendedProfileQuerySchema
-      .merge(pageQuerySchema)
-      .merge(limitlessQuerySchema)
-      .merge(includeRepliesQuerySchema),
+    query: commentActivityQuerySchema,
     responses: {
       200: commentResponseSchema.array(),
     },
@@ -307,10 +306,7 @@ const GLOBAL_LEVEL = builder.router({
     path: '/updates/:comment_type/:type',
     method: 'GET',
     pathParams: commentActivityParamsSchema,
-    query: extendedProfileQuerySchema
-      .merge(pageQuerySchema)
-      .merge(limitlessQuerySchema)
-      .merge(includeRepliesQuerySchema),
+    query: commentActivityQuerySchema,
     responses: {
       200: commentResponseSchema.array(),
     },