[SHI-448] Option for code executor image tags that don't match backend - #360
Merged
Conversation
Contributor
|
| Filename | Overview |
|---|---|
| charts/retool/templates/_helpers.tpl | Adds a direct code-executor tag override while preserving the existing backend-tag derivation as fallback. |
| charts/retool/templates/deployment_code_executor.yaml | Uses the workload pull policy first, but the accompanying nonempty default prevents existing global pull-policy configurations from being inherited. |
| charts/retool/values.yaml | Documents and exposes the tag override; the IfNotPresent pull-policy default unintentionally shadows the global setting. |
| charts/retool/ci/test-code-executor-image-tag-option.yaml | Supplies representative overrides, but CI only checks that the resulting manifests are schema-valid rather than asserting those values. |
| charts/retool/Chart.yaml | Bumps the chart minor version for the new image-override capability. |
| values.yaml | Mirrors the chart defaults, including the pull-policy default that prevents global inheritance. |
Reviews (1): Last reviewed commit: "updated helm chart logic to override the..." | Re-trigger Greptile
justinyang-retool
force-pushed
the
code-executor-image-name-mismatch
branch
from
August 12, 2026 04:06
c878998 to
5591567
Compare
justinyang-retool
force-pushed
the
code-executor-image-name-mismatch
branch
from
August 15, 2026 04:20
5591567 to
af02c39
Compare
ryanartecona
approved these changes
Aug 17, 2026
…age and backend image names dont match
…he test data better
justinyang-retool
force-pushed
the
code-executor-image-name-mismatch
branch
from
August 18, 2026 04:18
a97667c to
e88c857
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer making a Helm Chart update had with the one-off image they were using
tryretool/code-executor-one-offs:pr-3.334.6-fcf7211. The image name does not match the backend image which did not include the pr-. By design in the helm chart, we don't allow for differing image names between backend and code executor. There should be an option for the customer here to be able to override the image for codeExecutor in this case, or we need to make sure the names match.Note I've decided for now that pullpolicy will not be overrideable
Testing:
In-code testing:
Testing with no override:
Deploy testing:



Before case:
has the default image and the image pulled successfully
Also note the code executor has no image tag while the backend image tag is the one pulled:
After case:



Has the new image for code executor
Note that the code executor pulled successfully
THe pod
justinyang-test-547579fb56-nws4pis erroring out but this actually precedes the image override update, and it uses the default image so it's not affectedAlso note the helm chart: