-
Notifications
You must be signed in to change notification settings - Fork 77
[SHI-448] Option for code executor image tags that don't match backend #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
1cd3dcb
updated helm chart logic to override the image for codeExecutor if im…
justinyang-retool c8a5f95
Removed superfluous pull policy changes (since not needed) and made t…
justinyang-retool 16e5713
Addrssed PR comments
justinyang-retool e88c857
Removed pullpolicy
justinyang-retool File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
charts/retool/ci/test-code-executor-image-override-option.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # Code executor image WITH an override: both fields must be used verbatim and | ||
| # must not inherit from the top-level image.*. Overlaid onto each base | ||
| # *values.yaml by .github/kubeconform.sh. | ||
| # | ||
| # The repository and tag below are deliberately unlike the top-level image.*, so | ||
| # a regression that inherits the backend values, or that falls back to the | ||
| # chart's built-in default tag, changes the rendered image and fails the test. | ||
| # The tag must stay above the chart's code-executor and workflows version gates | ||
| # (>= 3.20.15 and >= 3.6.11), or the deployment is not rendered at all and the | ||
| # test silently asserts nothing. | ||
| image: | ||
| tag: 9.9.9-test | ||
|
|
||
| codeExecutor: | ||
| image: | ||
| repository: example/code-executor-service | ||
| tag: 8.8.8-test-override | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.