Skip to content

promote: develop를 data로 올린다 - #3034

Merged
twoimo merged 6 commits into
datafrom
develop
Sep 24, 2026
Merged

twoimo merged 6 commits into
datafrom
develop

Conversation

@twoimo

@twoimo twoimo commented Sep 24, 2026

Copy link
Copy Markdown
Owner

Summary

Test plan

  • develop PR #3033에서 Release와 Promotion Path 통과
  • data 머지 후 main 승격

Made with Cursor

twoimo and others added 2 commits September 24, 2026 17:13
홈은 뷰포트가 정해지기 전에 같은 크기의 스켈레톤을 그리고, 테두리·글자 스케일·관리자 배너 조회와 로컬 3000 포트를 맞춘다.

Co-authored-by: Cursor <cursoragent@cursor.com>
fix: 첫 화면 정적 스켈레톤과 스타일·관리자 지표
@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
tzudong Ready Ready Preview Sep 24, 2026 8:30am UTC

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T08:35:35.967405Z c71e812 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

develop가 data보다 뒤처져 다음 승격이 막혀 있어, 이미 data에 있는 머지 커밋만 포함한다.
…-20260924

sync: data 승격 머지를 develop에 포함한다

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 47e9342b76

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/web/app/home-runtime-shell.tsx
Comment thread apps/web/components/admin/AdminConsoleOverview.tsx
Comment thread apps/web/components/admin/AdminConsoleOverview.tsx
Comment thread apps/web/app/api/admin/banners/route.ts Outdated
Comment thread apps/web/hooks/use-ad-banners.tsx
접힌 패널이 지도를 가리지 않게 하고, 서비스 롤 설정 실패도 banner_read_failed로 막는다.

Co-authored-by: Cursor <cursoragent@cursor.com>
fix: 스켈레톤 해제와 배너 실패 코드
@twoimo
twoimo merged commit 6c7a28b into data Sep 24, 2026
38 of 41 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c71e812268

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +157 to +159
return () => {
delete document.documentElement.dataset.homeChromeReady;
};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the skeleton hidden after entering fullscreen

On mobile, home-client.tsx deliberately stops rendering HomeControlPanel while isMapFullscreen is true, so this cleanup removes data-home-chrome-ready even though the home map has already loaded. The persistent HomeStaticSkeleton then becomes visible again and overlays animated placeholder bars on the fullscreen map. Fresh evidence in the current tree is the new readiness cleanup combined with the fullscreen render condition; keep the loaded state independent of this conditionally mounted control panel, or remove the skeleton once real chrome has appeared.

Useful? React with 👍 / 👎.

Comment thread apps/web/package.json
Comment on lines +11 to +12
"dev": "node scripts/run-local-dev.mjs --port 3000",
"dev:local": "node scripts/run-local-dev.mjs --port 3000",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Protect the new default port from nightly runs

When a developer runs the newly configured default server and starts a local nightly run with APP_PORT=3000, validateLocalEnvironment in scripts/run-nightly-regression.mjs still rejects only the old protected port 8080, after which runBrowserRegression launches next dev --port 3000. The two processes then collide instead of the nightly runner failing closed during admission, which can invalidate local regression runs; migrate the protected-port check and its source-contract assertion together with this default.

Useful? React with 👍 / 👎.

This branch was successfully deployed

1 active deployment
Preview — c71e8122 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant