Purity annotations

[mernst]

Merge with:
typetools/jdk#294
plume-lib/plume-util#785
plume-lib/reflection-util#544

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: typetools/checker-framework/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 2d5b0b2b-0517-48af-926d-b52870aad5aa

📥 Commits

Reviewing files that changed from the base of the PR and between 7698e8d and 8505aac.

📒 Files selected for processing (3)

• checker/src/main/java/org/checkerframework/checker/lock/LockAnnotatedTypeFactory.java
• framework/src/main/java/org/checkerframework/common/basetype/BaseTypeVisitor.java
• framework/src/main/java/org/checkerframework/common/basetype/messages.properties

Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.

---

📝 Walkthrough

Walkthrough

The change annotates two comparison methods with @Pure. It maps @Pure and @SideEffectFree to LOCKINGFREE in lock side-effect analysis. It resolves callee elements for purity errors and includes the enclosing class and method name in purity messages.

Suggested reviewers: smillst

Priority: ⬇️ Low

Change: Feature

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 4 files. (1 skipped: 1 …
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}