Repository navigation
Annotate comparison methods as @Pure - #294
Merged
Merged
Conversation
Annotate all overrides of `Comparable.compareTo` in files that import Checker Framework annotations. `StringBuilder.compareTo` and `StringBuffer.compareTo` are upgraded from `@SideEffectFree` to `@Pure`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Annotate the remaining 125 overrides of `Object.equals` in files that import Checker Framework annotations. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Annotate the remaining comparison methods in files that import Checker Framework annotations: `isEqual`, `isBefore`, `isAfter`, `before`, `after`, `regionMatches`, `equalsIgnoreCase`, `contentEquals`, `mismatch`, `signum`, and the non-`Comparator` `compare` overloads. `Predicate.isEqual` is annotated `@SideEffectFree` rather than `@Pure`: it is a factory that returns a fresh lambda, so it is not deterministic. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`Executable.java` and `Member.java` use `@Pure` and `@SideEffectFree` without importing them, which breaks compilation. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Class.getMethod, getConstructor, getDeclaredField, getDeclaredMethod, and getDeclaredConstructor each end in a copyMethod/copyField/ copyConstructor call, so they return a freshly allocated object on every call and are not deterministic. Method.getTypeParameters and Method.getDeclaredAnnotations likewise return a new array on every call. Method.specificToStringHeader and specificToGenericStringHeader append to their StringBuilder parameter, so they are not side-effect-free either; remove the annotation rather than weakening it.
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge with:
typetools/checker-framework#8228
plume-lib/plume-util#785
plume-lib/reflection-util#544