Repository navigation
Support seconds in ZoneNameTimestamp human-readable serde deserialization - #8553
Merged
Manishearth merged 2 commits intoOct 7, 2026
Merged
Conversation
…de deserialization ZoneNameTimestamp::serialize emits 19-byte "YYYY-MM-DD HH:MM:SS" strings when the timestamp has non-zero seconds (such as ZoneNameTimestamp::far_in_past()), but ZoneNameTimestamp::deserialize rejected any string with length != 16.
Manishearth
requested review from
a team,
nekevss,
robertbastian and
sffc
as code owners
October 6, 2026 22:36
robertbastian
approved these changes
Oct 7, 2026
robertbastian
left a comment
robertbastian
left a comment
Member
There was a problem hiding this comment.
This used to be correct before #6942 introduced ZoneNameTimestamps with seconds.
Co-authored-by: Robert Bastian <4706271+robertbastian@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZoneNameTimestamp::serializeemits 19-byte"YYYY-MM-DD HH:MM:SS"strings when the timestamp has non-zero seconds (such asZoneNameTimestamp::far_in_past()), butZoneNameTimestamp::deserializerejected any string withlength != 16.Changelog
icU_time: Support seconds in ZoneNameTimestamp human-readable serde deserialization