Repository navigation
fix: keep the notification messages out of the user insert - #77
Merged
Merged
Conversation
Signed-off-by: Joey Smith <jsmith@webinertia.net>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a user from the admin modal failed with
Unknown column 'successMessage' in 'field list'.UserRepository::save()casts the command to an array and only droppedcommandName;CreateUserCommandnow has the publicsuccessMessageandfailureMessage(NotificationCapableInterface, #76), so they reached the INSERT.save()now drops all three.saveInsertsNewCommandAndReturnsGeneratedIdalready built aCreateUserCommandbut only assertedcommandName; it now asserts both messages too, and fails without the source change (verified).Found in the browser: valid create from the modal, after php-db/phpdb-validator#11 fixed the false-positive uniqueness check.
composer test: 364 tests, 1147 assertions, OK. Mago format, lint and analyze exit 0.