Repository navigation
fix(coord): coord.sh done works when no comment links a PR - #119
Merged
Merged
Conversation
Without --pr, done looks for a "pr: .../pull/N" comment. When none exists (a settings-only or decision issue), `last` is null, and capture() on a null body is a jq error, so done exited before posting DONE. Guard with select(. != null). coord.ps1 already checks for a match first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Open
xcjs
approved these changes
Oct 4, 2026
xcjs
left a comment
xcjs
left a comment
Owner
There was a problem hiding this comment.
Verified: guard matches coord.ps1's match-first pattern; author live-tested done 104 on this branch. Safe one-liner. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coord.sh done Nwithout--prlooks for apr: …/pull/Ncomment on the issue. When there isn't one, as with a settings-only or decision issue,lastisnull, andcapture()on a null body is a jq error:So
doneexited before posting DONE. This guards withselect(. != null).coord.ps1already checks for a match first. The merged-PR check is unchanged when a PR URL is found.Verification
coord.sh done 104(the e2e gate, a settings-only issue) posted DONE and closed 0.1 e2e gate: require the CI checks on main #104. On main, the same call fails with the error above.pr:comment → its URL; two → the last one.bash -nis clean.🤖 Generated with Claude Code