Repository navigation
fix(chat): return 401 without server env-var API-key fallback - #89
Merged
Merged
Conversation
Open
m-vawter
approved these changes
Oct 3, 2026
m-vawter
left a comment
Collaborator
There was a problem hiding this comment.
Approving. Verified locally: with this branch merged onto the #91 e2e suite, 3/3 pass, and the route now takes the key only from the request (the 401 path is unchanged). Two small things, neither blocking:
- The new comment cites ADR 0012, but NEXT.md frames this step as ADR 0005 conformance, the server-side provider proxy record. Citing 0005 would point readers at the decision this completes.
- A follow-up idea: a keyless local endpoint (Ollama through the custom OpenAI-compatible provider) still gets a 401, same as before. With a self-hostable north star, allowing an empty key for the custom provider might be worth an issue.
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80
Summary
Scope
\server/api/chat.post.ts\ only — matches issue #80's ## Files.
Done when (from #80)
Verification
pm run typecheck\ passes (exit 0)
g 'process\.env' server/api/chat.post.ts\ now shows only the two *_BASE_URL\ fallbacks (URLs, not keys) — env-var key reads are gone