Repository navigation
fix(coord): coord.sh done reads PR state with a field gh knows - #97
Merged
Merged
Conversation
`done` asked gh for `--json state,merged` whenever it had a PR URL. gh
has no `merged` JSON field ("Unknown JSON field: \"merged\""), so the
command exited before posting DONE. coord.ps1 already asks for
`state,mergedAt`; coord.sh now does the same. The merged check itself
is unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Open
xcjs
approved these changes
Oct 3, 2026
xcjs
left a comment
xcjs
left a comment
Owner
There was a problem hiding this comment.
Verified: main's coord.sh queries --json state,merged and gh rejects the unknown field; coord.ps1 already uses state,mergedAt. One-line fix is correct, mergeable state guard still functions. Approving as non-author.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coord.sh donestopped before posting DONE whenever it had a PR URL, from--pror from apr:comment. It asked gh for--json state,merged, and gh has nomergedfield:coord.ps1asks forstate,mergedAt, which is whydoneworks from PowerShell. This one-line change does the same incoord.sh. The merged check itself is unchanged.Verification
coord.sh done 79 --pr …/pull/91posted DONE on 0.1 Playwright end-to-end test of the core loop #79 (gh 2.92.0, macOS). On main, the same call fails with the error above.OPENfor feat(os): baseline Content Security Policy #90, sodonerefuses an unmerged PR, and it returnsMERGEDfor test: e2e Playwright test of the core loop (#79) #91.bash -nis clean.scripts/test/stub-gh.sh) doesn't check--jsonfield names, which is how this slipped through. That check is worth adding when the fixture harness coversdone.🤖 Generated with Claude Code