Repository navigation
[codex] fix update privacy and app rule restoration - #32
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeSwitch previously performed a silent Sparkle update probe during every normal launch even though the README stated that GitHub was contacted only after the user selected an update-related menu action. The same app-rule model also represented “ignored” as a replacement strategy, so restoring an ignored app discarded its previous fixed, follow-last, or default rule. Finally, the menu bar icon visually distinguished unconfigured apps without exposing the equivalent state to VoiceOver.
Root cause and user impact
The app entry point explicitly called
checkForUpdateInformation()after starting Sparkle. This caused an unprompted GitHub appcast request and made the documented privacy behavior inaccurate, although it did not automatically download or install updates.Ignoring an app overwrote its only strategy field with
.ignored, and both restore actions always wrote.none. Users temporarily ignoring a configured app therefore lost the rule they had selected before ignoring it.The menu bar accessibility label was a constant
TypeSwitch, while the icon changed according to the current app’s configuration state. VoiceOver users could not perceive the state represented by the badge.Changes
SUEnableAutomaticChecks=false; the update request now starts only when the user clicksCheck for Updates….strategyBeforeIgnoringfield to app rules..none.Validation
rtk just checkgit diff --cached --checkcheckForUpdateInformation,startSilentCheck, orSparkleUpdateMonitorreferences.