feat(command): add bounded command schema foundation - #216
Merged
Merged
Conversation
Refs #215. Keep Clap private behind an opt-in facade with bounded input and schema validation.
2 tasks
Refs #215. Add bounded optional values, repeated strings, relations, and exclusive groups.
Refs #215. Preserve nested command matches and bounded positional parsing.
Refs #215. Add typed f64 and u32 schema values with validated defaults.
Refs #215. Render deterministic command help without exposing Clap.
zackees
added a commit
to FastLED/cli
that referenced
this pull request
Sep 13, 2026
Refs zackees/kernal-api#216. Point the migration override at the command-schema facade.
zackees
added a commit
to FastLED/cli
that referenced
this pull request
Sep 13, 2026
Refs zackees/kernal-api#216. Parse toolchain and source command trees with the bounded kernel schema.
Refs #215. Enforce finite float values and defaults in the facade.
Refs #215. Keep internal options parseable while omitting them from help.
Refs #215. Add deterministic version metadata and rendering.
Refs #215. Apply option relations only to caller-supplied options.
Refs #215. Allow explicitly declared OS-string arguments without a lossy UTF-8 conversion while retaining bounded input validation and relation checks.
Refs #218. Provide owned errors, source chains, context helpers, and a Result alias without a third-party error carrier.
Owner
Author
|
Added the error-context migration support in b73b195, 9f978f2, and 073995a: bounded message construction, alternate source-chain rendering, |
Owner
Author
|
Added b2d3ec7 for the requested automatic GitHub release flow with registry publishing deferred behind explicit repository variables. Focused release-workflow tests and YAML parsing pass. |
zackees
added a commit
to FastLED/cli
that referenced
this pull request
Sep 13, 2026
Refs zackees/kernal-api#216. Point the migration override at the command-schema facade.
zackees
added a commit
to FastLED/cli
that referenced
this pull request
Sep 13, 2026
Refs zackees/kernal-api#216. Parse toolchain and source command trees with the bounded kernel schema.
zackees
marked this pull request as ready for review
September 13, 2026 18:06
This was referenced Sep 13, 2026
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the first bounded, facade-owned command-schema layer for #215.
clapremains a private, opt-in implementation detail; default consumers do not resolve it.This is intentionally a foundation rather than fastled-wasm adoption: optional values, repetition, conflicts, requirements, and help modelling still need the fuller schema requested by the issue.
Validation
soldr --no-cache cargo test --features command-schema --test command_schema_contractsoldr --no-cache cargo test --no-default-featuressoldr --no-cache cargo clippy --features command-schema --all-targets -- -D warningsStack
feat/json-documents/ feat(json): bounded owned JSON documents #212.