Skip to content

Clear recovery announcements when retained Review warnings return - #2924

Merged
Chris0Jeky merged 2 commits into
mainfrom
issue-2921/review-warning-recovery
Sep 10, 2026
Merged

Chris0Jeky merged 2 commits into
mainfrom
issue-2921/review-warning-recovery

Conversation

@Chris0Jeky

@Chris0Jeky Chris0Jeky commented Sep 10, 2026

Copy link
Copy Markdown
Owner

Summary

A successful list refresh followed by a failed pinned-proposal read can announce recovery while keeping hidden old rows. Revealing those rows restores their warning. This change clears the contradictory recovery announcement when that warning returns, without another network read.

Closes #2921

Verification

Source/test tree at 980f29b:

  • Both stale/refused real-Vue cases failed before repair and now pass. Focused Review: 199 passed.
  • npm run typecheck, npm run build, scoped ESLint: passed.
  • npx vitest --run --maxWorkers=2: 418 files, 6,462 passed, 3 existing skips.
  • Docs/GitHub-ops governance and git diff --check: passed.

Parent #2918 merged. This PR targets main at b3edd1e. Head 60f21ab integrates only the coordinator's AGENT_INDEX correction; backend/frontend trees are unchanged. Focused 199 tests and docs/link/diff checks pass again. Independent fresh-context review and scoped base-interaction review are clean. New-head hosted CI is pending.

No local backend run: only the composable and its regression spec change. No new browser run: real Vue scheduling proves this state transition; the parent contains browser proof of the unchanged warning binding. Real screen-reader speech is not verified.

Documentation and risk

No canonical doc change is needed for this bounded message-state correction. Existing recovery and no-extra-read controls remain covered. No polling cadence, permission, approve or apply policy changes. Separate scope/counter residuals are tracked in #2923.

Issue and PR are Review/Priority III; only #2921 is linked for closure after retarget. Logs and receipt: C:/Users/Public/codex-shell-home/taskdeck-alpha-evidence/2921/. Existing human actions in OUTSTANDING_TASKS.md remain open.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T17:40:32.117383Z 60f21ab New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Chris0Jeky Chris0Jeky moved this from Pending to Review in Taskdeck Execution Sep 10, 2026

Copy link
Copy Markdown
Owner Author

Independent fresh-context review: SHIP, no introduced CRITICAL/HIGH or new MEDIUM/LOW findings at 980f29b against parent 6a1f68f. Reviewed recovery kind/timing retirement, retained visibility and both real-Vue regression sequences. The reviewer did not rerun tests or query hosted metadata; local gate evidence is coordinator-run. #2923 remains the separate inherited scope/counter residual.

Project issue and PR are Review/Priority III. GitHub closing-issue references are empty while targeting the parent branch; the body references only #2921, and linkage will be checked again after retargeting to main. Parent #2918 must merge first; do not delete its branch while this PR targets it.

Base automatically changed from issue-2915/review-visible-health to main September 10, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Review] Retire recovery when a retained warning is restored

1 participant