Repository navigation
conformance: a generator-agnostic harness, and no generator dependency - #159
Merged
Merged
Conversation
added 2 commits
November 16, 2026 21:59
comline-conformance dev-depended on comline-codegen-rust and comline-codegen-typescript, which depend on comline-codegen here, so every core bump went round the cycle twice. The three suites that need a generator (the protocol round trip, the golden comparison, the support proofs) move into the crate as comline_conformance::harness, parameterised by a Generator, and each generator repository runs them over its own output against goldens it holds. generation now depends on core only; the [patch] that folded the two copies of comline-codegen into one goes with the dev-deps. The goldens and the combined FEATURES.md/features.json leave with the generators: each generator's repository holds its own goldens and its own report.
This was referenced Nov 16, 2026
Kinflou
marked this pull request as ready for review
November 16, 2026 15:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the dependency cycle between this repository and the two generator repositories.
The cycle
comline-conformancedev-depended oncomline-codegen-rustandcomline-codegen-typescript, and both of those depend oncomline-codegenhere. Every core bump took four rounds: pin generation, pin the generators to it, re-pin generation's conformance to the generators, re-pin the generators to generation's merge. A[patch]in the workspace folded the two copies ofcomline-codegeninto one.The change
generation depends only on core. What needed a generator moves to the generators:
conformance/src/harness.rs(new,comline_conformance::harness): the generator-agnostic half of the oldconformance/tests/conformance.rs. A generator describes itself as aGenerator(language,generate,register,SUPPORT,VERSIONS) and callscorpus_matches_golden,the_protocol_generates_what_the_generator_doesandsupport_is_proven. The logic is the old test's, parameterised by one generator instead of looping overLANGS; the goldens root and the report directory are arguments.conformance/tests/conformance.rsandconformance/tests/golden/are removed. The goldens are in comline-rust#138 and comline-typescript#177, byte-identical (sha256 of each of the 136 files unchanged; nothing re-blessed).conformance/tests/dependency_protocols.rsandnested_protocols.rsstay: they need no generator.[patch."https://github.com/ComlineProject/generation"]section are gone.eyreandserde_jsonbecome normal dependencies ofcomline-conformance, since the harness uses them.FEATURES.mdandfeatures.jsonare removed. Writing them needed both generators in one build. Each generator now writes its own (generatorsholding one entry; itsfeatureslist is the same), andfeatures.jsonis exactly the old file's entry for that generator.Consumers of the combined
features.json(not changed here)It is read from this repository's
masterbydocs(scripts/sync-language-support.py,--file/--rev, and the weeklylanguage-support-drift.yml) and by the Observatory (sources.toml, sourcecodegen,repo = "generation"). Merging this before they read the generators' files breaks both. The Observatory already combines sources with the samematrix, so it needs a second source entry. The docs script needs to read the two files and join theirgenerators.Order
The generators pin this branch's head (
31e808ff) until this merges; they re-pin after.