Repository navigation
Conversation
dnlbui
added this pull request to stack #88
October 5, 2026 16:26
dnlbui
marked this pull request as ready for review
October 5, 2026 16:26
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
The multiple-attachment download scenario now uses
AttachmentMenu.open()to scroll the target into view and wait for stable position/layout across rendered frames before opening Save. The wait is bounded at five seconds.The named download waiter starts only after Save is visible and is awaited together with the Save click. Existing filename, size, and byte-for-byte checks remain intact.
Fixed Flow
Scroll attachment into view → wait for scrolling/layout to settle → open and verify Save → start the waiter and click Save together → verify downloaded bytes.
Why
Playwright's implicit scrolling could deliver a scroll event just after the attachment click, closing the newly opened menu as the client intends. The old waiter also remained active when menu opening failed, producing a secondary page-closed error during cleanup.
No client behavior or visibility timeout changes are included. Shared failure evidence before recipient cleanup follows in the next stacked issue, #78.
Validation
Against
https://liberdus.com/dev/, fromplaywright-tests/:Stacked on #82, base
test/update-account-option-selectors.Closes #79