Skip to content

feat(ui): stack the agent log panel in narrow panes - #1787

Merged
trunk-io[bot] merged 1 commit into
compass-ui/rig-4446-split-panefrom
compass-ux/4682-narrow-agent-view
Oct 7, 2026
Merged

trunk-io[bot] merged 1 commit into
compass-ui/rig-4446-split-panefrom
compass-ux/4682-narrow-agent-view

Conversation

@rigel-mintaka

@rigel-mintaka rigel-mintaka commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

This PR is part of a stack containing 3 PRs:

  1. main
  2. "feat(ui): stack the agent log panel in narrow panes" (this PR)
  3. feat(ui): New tab always opens a new tab #1798
  4. fix(ui): keep the Bridge Issues/PRs toggle in place #1812

A view panel is now a named inline-size container. Below 560px, the agent
view moves its log panel from a 340px right column into a bottom row
capped at 40% of the height. The handle stays whole, the model and cwd
truncate so Share stays in view, and the minimize caret points down/up.
A ~318px split pane no longer clips the body or header.

Adds the narrow-pane visual shot and refreshes split-view.png, whose
right pane is the narrow agent view. Both are local captures under the
pinned dev shell (DL-399).

Spec-impact: none
Refs RIG-4682

Co-authored-by: Matt Wilkinson matt@rigel.build

Summary

The agent view now fits narrow split panes. Before, a ~318px pane clipped it, because the 340px log panel sat in a right-hand column.

  • .view-panel is now a named inline-size container (view-panel). It is the box every routed view fills, in both single and split layouts. An element cannot query its own size, so the query sits on the panel rather than on .agent-view.
  • Below 560px of pane width, .agent-view stacks its log panel as a bottom row capped at 40% of the height. The trace scrolls inside that cap. The minimized rail becomes a one-line bottom bar, and the caret points down to minimize and up to expand.
  • In the same width range, the agent handle stays on one line, and the model and cwd truncate with an ellipsis so Share stays visible.
  • This stacks the panel instead of auto-minimizing it. logOpen is one store signal shared by every pane, so minimizing it for a narrow pane would also close the panel in a wide one.

Verification

  • visual-gate: 15 passed.
    • New shot narrow-pane.png: the agent pane of a W V split.
    • Refreshed split-view.png: its right pane is the narrow agent view.
    • Both are local captures under the pinned dev shell (DL-399).
    • With the container query disabled, both shots fail.
    • The other 13 shots, including agent.png (the wide agent view), still match.
  • Chromium probe in the split: .agent-view scrollWidth equals clientWidth (318) with the log panel open and minimized. Before the change, scrollWidth was 441.
  • compass-ui:stylelint, typecheck and dev-smoke pass, and Biome is clean on the spec. compass-ui:test passes 1292; the 4 env-secrecy tests fail only because a jj workspace has no .git.

Risks

  • Containment applies to every view inside .view-panel. Each panel takes its width from its flex parent, never from its content, and overlays render outside it. The 13 unchanged shots cover the other views.
  • 560px is a judgment call: it leaves the body about 220px beside a 340px panel.

Compatibility

CSS only. No API or store change.

Documentation

None.

Refs RIG-4682

A view panel is now a named inline-size container. Below 560px, the agent
view moves its log panel from a 340px right column into a bottom row
capped at 40% of the height. The handle stays whole, the model and cwd
truncate so Share stays in view, and the minimize caret points down/up.
A ~318px split pane no longer clips the body or header.

Adds the narrow-pane visual shot and refreshes split-view.png, whose
right pane is the narrow agent view. Both are local captures under the
pinned dev shell (DL-399).

Spec-impact: none
Refs RIG-4682

Co-authored-by: Matt Wilkinson <matt@rigel.build>
@trunk-io

trunk-io Bot commented Oct 6, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@linear-code

linear-code Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

RIG-4439

RIG-4682

@rigel-mintaka rigel-mintaka changed the title refactor(ui): extract parseRoute and add ViewScope with useView (RIG-4439) feat(ui): stack the agent log panel in narrow panes Oct 6, 2026
@rigel-mintaka
rigel-mintaka changed the base branch from main to compass-ui/rig-4446-split-pane October 6, 2026 12:56
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

Compass engineering docs preview: https://compass-ux-4682-narrow-agent.compass-eng-docs.pages.dev

Deployed from compass-ux/4682-narrow-agent-view at 209d386.

@rigel-mintaka
rigel-mintaka marked this pull request as ready for review October 6, 2026 13:23
@rigel-mintaka
rigel-mintaka changed the base branch from compass-ui/rig-4446-split-pane to main October 6, 2026 18:13
@rigel-mintaka
rigel-mintaka changed the base branch from main to compass-ui/rig-4446-split-pane October 6, 2026 18:13
@rigel-mintaka
rigel-mintaka changed the base branch from compass-ui/rig-4446-split-pane to main October 6, 2026 23:46
@rigel-mintaka
rigel-mintaka changed the base branch from main to compass-ui/rig-4446-split-pane October 6, 2026 23:46
@mattwilkinsonn
mattwilkinsonn added this pull request to stack #1838 October 7, 2026 00:43
@trunk-io

trunk-io Bot commented Oct 7, 2026

Copy link
Copy Markdown

This pull request is queued for merge as part of 1798, which will merge 1652, 1675, 1743, 1755, 1770, 1780, 1787, 1798.

@trunk-io
trunk-io Bot merged commit f3ee331 into main Oct 7, 2026
73 of 97 checks passed
@trunk-io
trunk-io Bot deleted the compass-ux/4682-narrow-agent-view branch October 7, 2026 04:16
@trunk-io

trunk-io Bot commented Oct 7, 2026

Copy link
Copy Markdown

This pull request was merged into main as part of stacked PR 1798.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants