Repository navigation
feat(ui): New tab always opens a new tab - #1798
Merged
trunk-io[bot] merged 1 commit intoOct 7, 2026
Merged
trunk-io[bot] merged 1 commit into
trunk-io[bot] merged 1 commit into
Conversation
The open action gains an optional `fresh` flag that skips the same-path dedupe. Only `tab.new` sets it, so W N and the palette's "New tab" always open a Bridge tab after the active one, even when Bridge is already open. Links, Mod+click and deep links still dedupe. The 10-tab cap still refuses with the layout notice. Records the ruling as DL-409, amending DL-390's dedupe clause for this command. Spec-impact: none Refs RIG-4676 Co-authored-by: Matt Wilkinson <matt@rigel.build>
|
Compass engineering docs preview: https://compass-ux-4676-new-tab-fres.compass-eng-docs.pages.dev Deployed from Changed pages: |
rigel-mintaka
marked this pull request as ready for review
October 6, 2026 18:38
This was referenced Oct 6, 2026
mattwilkinsonn
added this pull request to stack #1838
October 7, 2026 00:43
mattwilkinsonn
approved these changes
Oct 7, 2026
Contributor
|
/trunk merge --priority=high |
|
😎 Stack merged successfully - details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 3 PRs:
mainSummary
Applies Matt's ruling B on RIG-4676: New tab (
W N, and the palette's "New tab") always opens a new Bridge tab, even when Bridge is already open.openlayout action gets an optionalfreshflag that skips the same-path dedupe. Onlytab.newsets it.Mod+click and deep links still dedupe to an open tab.tools/dl-claim).Verification
compass-ui:testpasses 1294; the 4 env-secrecy tests fail only because a jj workspace has no.git.typecheck,dev-smoke,visual-gate(15) anddesign-ledger-gate:checkpass. Biome and rumdl are clean./#/, pressingW Ntakes the strip from 1 tab to 2, and the hash stays/.Risks
/), and every layout consumer keys by view id or tab id, not by path./focuses the first one in tab order. This was already the behaviour before this change.Compatibility
freshis optional and defaults to false, so every existingopendispatch keeps its behaviour.Documentation
Ledger row DL-409 in
docs/designs/DECISIONS.md.Ledger-impact: appends DL-409 (amends DL-390 for New tab).
Refs RIG-4676