Repository navigation
feat(forge): read PR timestamps, closing refs and PR list rows (RIG-4034) - #1914
Open
rigel-mintaka wants to merge 1 commit into
Open
rigel-mintaka wants to merge 1 commit into
rigel-mintaka wants to merge 1 commit into
Conversation
|
Compass engineering docs preview: https://compass-obs-rig-4034-t2-forg.compass-eng-docs.pages.dev Deployed from |
…034) forge.PullRequest gains CreatedAt, UpdatedAt and ClosingRefs. The full GraphQL read fetches closingIssuesReferences on its first page only. ListUpdatedIssues returns the PR rows beside the issues, and ListOpenPullRequests lists open PRs for the backfill. The store gains PullRequestUpdatedAt, PRsBackfilledAt and MarkPRsBackfilled. Spec-impact: none. Refs RIG-4034 Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
force-pushed
the
compass-obs/rig-4034-t2-forge-reads
branch
from
October 7, 2026 06:21
ffb727f to
5677e58
Compare
This was referenced Oct 7, 2026
rigel-mintaka
marked this pull request as ready for review
October 7, 2026 11:09
mattwilkinsonn
added this pull request to stack #1947
October 8, 2026 03:17
mattwilkinsonn
approved these changes
Oct 8, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 6 PRs:
mainSummary
This is T2 of the PR-to-issue linkage design (
docs/designs/server/compass-issue-model-pr-linkage-amendment/design.md, §4). It stacks on #1900. The reconciler and the projection consume these reads in T3 and T5.forge.PullRequestgainsCreatedAt,UpdatedAtandClosingRefs []IssueRef. Both the create response and the detail read decode the timestamps.pullReadQueryreadsclosingIssuesReferences(first: 25)behind$refs.ListUpdatedIssuesreturnsUpdatedRows{Issues, Pulls}: PR rows come back in order beside the issues instead of being dropped. The reconciler still sinks onlyIssues.ListOpenPullRequestsis added for the backfill pass.PullRequestUpdatedAt,PRsBackfilledAtandMarkPRsBackfilled.Verification
go test ./..., plus pgtest for store, server, ingest and forge, pass.golangci-lintreports no new findings.created_atis canonicalized for live capture.Risks
Every PR read now costs one extra GraphQL connection on its first page, inside a call that was already being made.
Compatibility
Internal Go only. No wire or schema change.
Documentation
None. The design record already describes the change.
Refs RIG-4034