Repository navigation
feat(forge): link a created pull request to its issue (RIG-4034) - #1926
Open
rigel-mintaka wants to merge 3 commits into
Open
rigel-mintaka wants to merge 3 commits into
rigel-mintaka wants to merge 3 commits into
Conversation
This was referenced Oct 7, 2026
|
Compass engineering docs preview: https://compass-obs-rig-4034-t4-crea.compass-eng-docs.pages.dev Deployed from Changed pages: |
create_pull_request takes an optional issue coordinate. The server checks its shape only, then writes the ownership row, the PR row and the explicit link in one transaction and republishes the linked issue. The agent tool gains the issue parameter and the role prompts tell agents to pass it. Spec-impact: none. Refs RIG-4034 Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
force-pushed
the
compass-obs/rig-4034-t4-create-link
branch
from
October 7, 2026 07:02
31e8399 to
e964938
Compare
Board ingestion never refreshes a PR outside an enabled subscription, so the create path writes only the explicit link there; the link attaches once a hydrate stores the row. Spec-impact: none. Refs RIG-4034 Co-authored-by: Matt Wilkinson <matt@rigel.build>
Create-path tests seed an enabled subscription so the gated insert runs and the hydrated-row-wins check stays live. Spec-impact: none. Refs RIG-4034 Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
marked this pull request as ready for review
October 7, 2026 11:09
mattwilkinsonn
added this pull request to stack #1947
October 8, 2026 03:17
mattwilkinsonn
approved these changes
Oct 8, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 6 PRs:
mainSummary
This is T4 of the PR-to-issue linkage design (
docs/designs/server/compass-issue-model-pr-linkage-amendment/design.md, §1 and §3). It stacks on #1917.create_pull_requesttakes an optionalissuelink. The server checks only its shape and never reads the issue:number0 is rejected withinvalid_argument;not_found;invalid_argument.created_at;forge_updated_atis the epoch, so the next hydrate always wins.IssueProjection.PublishExplicitLinkthen republishes the target issue, plus the issues whose closing-ref fallback it took over.forge_create_pull_requestgainsissue(selector +repo+number).Verification
forge_created_atstored, and that a later hydrate replaces the row.go test ./..., pgtests,golangci-lint,bun test,tscandbiomeall pass.Risks
A failed publish after the commit is only logged; the next issue hydrate heals the cache.
Compatibility
CreatePullRequestRequest.issueis additive (it lands in #1900).Documentation
packages/compass-agent/AGENTS.mddocuments the new tool parameter.Spec-impact: none. Refs RIG-4034