Repository navigation
feat(board): show linked pull requests on board issues (RIG-4034) - #1917
Open
rigel-mintaka wants to merge 4 commits into
Open
rigel-mintaka wants to merge 4 commits into
rigel-mintaka wants to merge 4 commits into
Conversation
This was referenced Oct 7, 2026
rigel-mintaka
changed the title
|
Compass engineering docs preview: https://compass-obs-rig-4034-t3-proj.compass-eng-docs.pages.dev Deployed from |
…e (RIG-4034) Board issues keep the ingested repo casing, while links store GitHub repos lowercased, so the explicit-target check now lowercases issues.repo. Spec-impact: none. Refs RIG-4034 Co-authored-by: Matt Wilkinson <matt@rigel.build>
IssueProjection gains PublishPullRequestUpdate, which stores a hydrated PR and republishes every issue it gained or lost. PublishIssueUpdate, Rehydrate, SearchIssues and SetIssueState load prs from the store; RecordAndPublish keeps the cached prs. An issue that becomes an explicit target republishes the closing-ref issues it takes PRs from. Spec-impact: none. Refs RIG-4034 Co-authored-by: Matt Wilkinson <matt@rigel.build>
A projection-wide write lock now spans each store read and the cache write it feeds, so a slower PR or issue publish cannot cache an older list or row. A transition re-reads the issue under that lock and loads prs on a cache miss. Stored PRs decode with unknown fields discarded, number-0 rows skip the PR lookup, and the board join gets an expression index. Spec-impact: none. Refs RIG-4034 Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
force-pushed
the
compass-obs/rig-4034-t3-projection
branch
from
October 7, 2026 06:21
92ce48b to
758b062
Compare
This was referenced Oct 7, 2026
…4034) Migrations are append-only per PR base, so the index the T3 review fix added to the link migration moves to a new numbered migration. Spec-impact: none. Refs RIG-4034 Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
marked this pull request as ready for review
October 7, 2026 11:09
mattwilkinsonn
added this pull request to stack #1947
October 8, 2026 03:17
mattwilkinsonn
approved these changes
Oct 8, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack containing 6 PRs:
mainSummary
This is T3 of the PR-to-issue linkage design (
docs/designs/server/compass-issue-model-pr-linkage-amendment/design.md, §5). It stacks on #1914.IssueProjection.PublishPullRequestUpdate(ctx, ingest.IngestedPullRequest):prsfor every issue that gained or lost the PR;Prson a clone of the cached issue.prs:PublishIssueUpdateandRehydrateload from the store, in bulk forRehydrate.RecordAndPublishcarries the cachedprsacross a state change.SetIssueStatereturns the cached issue'sprs.SearchIssuesloads them in one query.ingest.IngestedPullRequestis the seam type. T5 adds the sink that feeds it.lower(issues.repo)for GitHub. It comes with a regression pgtest.Verification
prs;Rehydrate.go test ./..., plus pgtest for board, store, server and ingest, pass.golangci-lintreports no new findings.Risks
PublishIssueUpdatenow runs one extra query forprsand one fallback query per issue upsert.Compatibility
Wire
Issue.prsis now populated. The field already existed.Documentation
None. The design record already describes the change.
Refs RIG-4034