[albertlast]

Description

The statistics centre's topic starters list counts the twenty members with the most topics, looks their names up, and places each by rank:

$i = array_search($row_members['id_member'], array_keys($members));

// skip all not top 10
if ($i > 10) {
	continue;
}

Two things go wrong with that:

• $i > 10 keeps ranks 0 to 10, which is eleven. Every other list on the page has ten.
• A starter with no member to name keeps its place empty. Topics credited to member 0 (guests) or to a deleted member are counted, but the name lookup finds nobody, so that rank is skipped and the list is one shorter than it should be.

The two faults can cancel out: on a forum where one of the top eleven is a guest, the list shows ten. That also means fixing only the > would leave a gap.

It now takes the members that were found, in rank order, and keeps the first ten.

Tests

tests/Integration/Http/StatsStartersTest.php, with members and topics made for the test and removed afterwards:

• eleven members with two topics each: the list has ten entries. Before the fix it has eleven.
• the same, plus three topics credited to member 0, ranked first: still ten. With only > changed to >=, this one gets nine.

Both pass on MySQL and PostgreSQL. tests/Integration/Http is not part of the CI run yet.

2.1.7 has the same code. #9722 changes the query that feeds this list, but not these lines.

Issues References (Fixes|Related|Closes)

Related: #9722

🤖 Generated with Claude Code