Repository navigation
Conversation
Selection.Prefers walked every path in the selected slices regardless of the "arch" field, so a package listing a path only for other architectures still won the "prefer" relationship on the requested one. The losing package then skipped the path during extraction and nothing provided it, without any error. The selection now records the architecture it was made for and Prefers skips listings that do not apply to it.
prefer ignores x-arch paths
Contributor
Author
|
mmm... 🤔 lemme check that this kind of bug does not accidentally extend to release validation too... edit: no |
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
0 open findings
What changed in this PR
Fixes architecture-aware prefer resolution so paths restricted to other architectures do not suppress valid providers.
Changes:
- Records the selected architecture.
- Filters architecture-inapplicable preferred paths.
- Adds setup and slicer regression tests.
| File | Description |
|---|---|
internal/setup/setup.go |
Tracks architecture and filters preferences. |
internal/setup/setup_test.go |
Tests architecture-specific preference selection. |
internal/slicer/slicer_test.go |
Adds end-to-end regression coverage. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 10, 2026
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
did some formal verification (fizzbee, my specs are here and here) of the
cutpath and found 7 minor bugs:preferignores x-arch paths #330 (this PR)mutable: true, until: mutate#331until: mutate#333for some non-amd64 arch:
no error from cut. /file silently missing.
repro using
chisel-proxy:fix
Selectionnow records the arch it was made for (Selectalready takes it) andPrefersskips listings that do not apply to it.