Repository navigation
Conversation
addKnownPath registered the parents of a known path with empty data and never replaced them, so a directory first seen as the parent of an extracted file lost the "until: mutate" of its own explicit entry when that entry was processed later. Generated content is created after the extraction and iterates a map, so this happened every time for a made directory with an extracted child, and at random for a generated directory with a generated child. Implicit parents are now marked as such and an explicit entry replaces them.
This was referenced Oct 10, 2026
There was a problem hiding this comment.
🟢 Approval recommended
The fix is covered by regression tests and has no unresolved review issues.
0 open findings
What changed in this PR
Fixes implicit parent paths so explicit metadata, including until: mutate, is preserved.
Changes:
- Tracks implicit parent paths.
- Lets explicit entries replace implicit parents.
- Adds regression tests.
| File | Description |
|---|---|
internal/slicer/slicer.go |
Updates path registration logic. |
internal/slicer/slicer_test.go |
Adds regression coverage. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
did some formal verification (fizzbee. my specs are here and here btw) of the
cutpath and found 7 minor bugs:preferignores x-arch paths #330mutable: true, until: mutate#331until: mutate#333/dir/fileis removed after mutate,/dir/is not.repro using
chisel-proxy:the same happens for a generated directory with a generated child (
/gen/: {make: true, until: mutate}+/gen/text: {text: data1, until: mutate}), but there it depends on map iteration order and the directory survives roughly half of the runs.fix
addKnownPathregisters the parents of a known path with empty data and never replaces them. extracting/dir/fileregisters/dir/as an implicit parent, and when the explicit/dir/entry is created afterwards itsuntil: mutateis dropped.implicit parents are now marked as such and an explicit entry replaces them. an explicit entry still wins over a later explicit one, as before.