Repository navigation
Conversation
When several slices list the same path and only some of them say "until: mutate", the path stays in the rootfs. Extracted content is then attributed in the manifest to the slices that did not say it, while generated content was attributed to every lister, including the ones that asked for the path to be removed. Generated content now follows the same rule as extracted content: a slice that says "until: mutate" is never an owner of the path in the manifest. No release branch has a generated path listed that way, so no published manifest changes.
1 task done
This was referenced Oct 10, 2026
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
0 open findings
What changed in this PR
Fixes manifest ownership for generated paths using until: mutate, aligning them with extracted-content behavior.
Changes:
- Excludes mutating slices from generated-path ownership.
- Updates and expands attribution tests.
| File | Description |
|---|---|
internal/slicer/slicer.go |
Corrects generated path attribution. |
internal/slicer/slicer_test.go |
Verifies generated and extracted ownership behavior. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
until: mutate
This was referenced Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
did some formal verification (fizzbee, my specs are here and here) of the
cutpath and found 7 minor bugs:preferignores x-arch paths #330mutable: true, until: mutate#331until: mutate#333 (this PR)myslice1asked for/fileto be gone after mutate, yet the manifest lists it as an owner. for extracted content (copy) in the same situation theuntil: mutateslice is not listed; the two paths throughslicer.Rundisagree.repro using
chisel-proxy:with the fix,
slicesis["test-package_myslice2"].fix
generated content now does what extracted content does: a slice with
until: mutateon a path is not an owner of that path. the existing test pinning the old behaviour is flipped, and a second case pins the extracted side.no slice on any
ubuntu-*branch has a generated path listed like this (the mixed-untilpairs that exist,ca-certificatesmozilla glob andlibpam-runtimepam defaults, are all extracted), so no published manifest changes.