Conversation
…ditive) First, non-breaking step of the pluck/lists pipeline. value($column) is a copy of today's scalar pluck() body on both Query\Builder and Eloquent\Builder — value() === pluck() for scalars right now. Purely additive: no call-site changes behavior, pluck() untouched. Unblocks app 2.5b (->pluck()->->value()) WITHOUT flipping pluck semantics, so the repos never flip in the same instant. Tests: value() returns the scalar and equals pluck() (Query + Eloquent). Database suite 516 green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
Superseded by #64 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Langkah pertama & non-breaking dari pluck/lists pipeline (task 2.5). Independen dari 2.5e.
Perubahan
value($column)diQuery\Builder+Eloquent\Builder— copy body scalarpluck()sekarang.value()===pluck()buat scalar saat ini.pluck()nggak disentuh, nol call-site berubah behavior. Zero lockstep.Kenapa additive dulu
value()harus ada di fork sebelum app bisa konversi->pluck()→->value()(task 2.5b). Ini bikin dua repo nggak pernah flip barengan. App udah 2× kenavalue()-missing (commitb493f38e,fc90c75) — PR ini yang benerin akarnya.Verifikasi
value()balikin scalar & sama denganpluck()(Query + Eloquent).🤖 Generated with Claude Code