refactor(engine): manage child process lifecycles#2160
Open
jrusso1020 wants to merge 1 commit into
Open
Conversation
This was referenced Jul 10, 2026
Collaborator
Author
This was referenced Jul 10, 2026
jrusso1020
force-pushed
the
07-10-refactor_engine_manage_child_processes
branch
from
9295542 to
1a9af9b
Compare
jrusso1020
force-pushed
the
07-10-refactor_engine_add_browser_leases
branch
from
246c941 to
fa435fb
Compare
jrusso1020
force-pushed
the
07-10-refactor_engine_manage_child_processes
branch
2 times, most recently
from
131f444 to
f906eee
Compare
jrusso1020
force-pushed
the
07-10-refactor_engine_add_browser_leases
branch
from
fa435fb to
e9734f0
Compare
jrusso1020
force-pushed
the
07-10-refactor_engine_manage_child_processes
branch
from
f906eee to
bfe60e6
Compare
jrusso1020
force-pushed
the
07-10-refactor_engine_add_browser_leases
branch
from
1dd7199 to
82cdfe7
Compare
jrusso1020
force-pushed
the
07-10-refactor_engine_manage_child_processes
branch
2 times, most recently
from
5e82fec to
fc61671
Compare
jrusso1020
force-pushed
the
07-10-refactor_engine_add_browser_leases
branch
from
82cdfe7 to
5f2aacb
Compare
jrusso1020
force-pushed
the
07-10-refactor_engine_manage_child_processes
branch
2 times, most recently
from
b683ddb to
4e86382
Compare
jrusso1020
force-pushed
the
07-10-refactor_engine_add_browser_leases
branch
2 times, most recently
from
78ee37c to
263a1a1
Compare
jrusso1020
force-pushed
the
07-10-refactor_engine_manage_child_processes
branch
2 times, most recently
from
1a7d917 to
7dd4686
Compare
jrusso1020
force-pushed
the
07-10-refactor_engine_add_browser_leases
branch
from
406ba14 to
a53a699
Compare
jrusso1020
force-pushed
the
07-10-refactor_engine_manage_child_processes
branch
from
7dd4686 to
8733675
Compare
jrusso1020
force-pushed
the
07-10-refactor_engine_add_browser_leases
branch
from
a53a699 to
ae6769c
Compare
jrusso1020
force-pushed
the
07-10-refactor_engine_manage_child_processes
branch
from
8733675 to
223e861
Compare
jrusso1020
force-pushed
the
07-10-refactor_engine_add_browser_leases
branch
from
ae6769c to
3335e20
Compare
jrusso1020
force-pushed
the
07-10-refactor_engine_manage_child_processes
branch
4 times, most recently
from
eda0bb1 to
c0bd5b9
Compare
jrusso1020
force-pushed
the
07-10-refactor_engine_add_browser_leases
branch
from
248ec97 to
d35fc32
Compare
jrusso1020
force-pushed
the
07-10-refactor_engine_manage_child_processes
branch
2 times, most recently
from
571341a to
606e05b
Compare
jrusso1020
force-pushed
the
07-10-refactor_engine_add_browser_leases
branch
from
d35fc32 to
4f12432
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Give FFmpeg and related subprocesses one managed lifecycle.
Why
Timeout, cancellation, stderr bounds, and SIGTERM/SIGKILL behavior were duplicated and inconsistent across encoding phases.
How
Add ManagedChildProcess with composed signals, grace escalation, guaranteed reap, and typed termination reasons, then migrate encode/probe/extract paths.
Test plan