Skip to content

test(engine): isolate peer abort regression#2173

Open
jrusso1020 wants to merge 1 commit into
07-10-refactor-cli-decompose-render-phasesfrom
07-10-test-engine-isolate-peer-abort-regression
Open

test(engine): isolate peer abort regression#2173
jrusso1020 wants to merge 1 commit into
07-10-refactor-cli-decompose-render-phasesfrom
07-10-test-engine-isolate-peer-abort-regression

Conversation

@jrusso1020

@jrusso1020 jrusso1020 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

What

Isolate the engine peer-abort regression test from unrelated production dependency loading.

Why

The test used importOriginal for a large module graph, causing full-matrix timeouts that obscured the cancellation behavior it was meant to protect.

How

Replace the partial importOriginal mock with a complete minimal dependency mock and keep the assertion focused on aborting peer workers after the first fatal classified failure.

Test plan

  • Focused peer-abort regression
  • Complete Engine suite and non-Producer package matrix

This was referenced Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch 2 times, most recently from f57212b to eea1424 Compare July 13, 2026 20:33
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 841ca28 to 99291ad Compare July 13, 2026 20:33
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from eea1424 to a66407f Compare July 13, 2026 22:09
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 260558c to f6dfed1 Compare July 13, 2026 22:18
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from a66407f to 3f82ade Compare July 13, 2026 22:18
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from f6dfed1 to 50cf30c Compare July 13, 2026 23:08
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from 3f82ade to 195ebe8 Compare July 13, 2026 23:08
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 50cf30c to a36d53c Compare July 14, 2026 00:03
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch 2 times, most recently from 7bc03fb to 519e384 Compare July 14, 2026 03:20
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch 2 times, most recently from 23fae65 to ffda4eb Compare July 14, 2026 17:03
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from 519e384 to 4a63b75 Compare July 14, 2026 17:03
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from ffda4eb to b84837b Compare July 14, 2026 17:11
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch 2 times, most recently from 5537a7f to 47c96ed Compare July 14, 2026 17:35
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from b84837b to 35ae1d2 Compare July 14, 2026 17:35
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch 3 times, most recently from a0c92bc to aadfd4d Compare July 14, 2026 19:37
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 05b117e to b418569 Compare July 14, 2026 19:37
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from aadfd4d to bc585c6 Compare July 14, 2026 19:42
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from b418569 to 741b993 Compare July 14, 2026 19:42
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from bc585c6 to 71575e2 Compare July 14, 2026 19:47
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch 2 times, most recently from 4ed9cff to eb7cb8e Compare July 14, 2026 19:49
@jrusso1020 jrusso1020 force-pushed the 07-10-test-engine-isolate-peer-abort-regression branch from 71575e2 to 2165a08 Compare July 14, 2026 19:49
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from eb7cb8e to e743638 Compare July 14, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant