Skip to content

test(repo): execute packed subpaths#2169

Merged
jrusso1020 merged 2 commits into
mainfrom
07-10-test-repo-execute-packed-subpaths
Jul 19, 2026
Merged

test(repo): execute packed subpaths#2169
jrusso1020 merged 2 commits into
mainfrom
07-10-test-repo-execute-packed-subpaths

Conversation

@jrusso1020

@jrusso1020 jrusso1020 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

What

Execute every promised packed subpath in clean Node and browser consumers.

Why

Manifest generation alone cannot prove that an exported subpath installs, resolves peers, or bundles in its declared environment.

How

Install packed tarballs, import all Node promises, typecheck consumer code, and run a Vite browser build according to descriptor environments.

Test plan

  • 94 packed exports resolved; 89 Node exports executed; TypeScript and Vite consumer validation
  • Stack-wide lint, format, build, typecheck, and relevant integration gates

jrusso1020 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-repo-centralize-package-subpaths branch from 554f049 to 81f0609 Compare July 13, 2026 22:18
@jrusso1020
jrusso1020 force-pushed the 07-10-test-repo-execute-packed-subpaths branch 3 times, most recently from e656e66 to dab294d Compare July 14, 2026 00:03
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-repo-centralize-package-subpaths branch from 4a8cbbd to f064103 Compare July 14, 2026 03:20
@jrusso1020
jrusso1020 force-pushed the 07-10-test-repo-execute-packed-subpaths branch from dab294d to 72cafdf Compare July 14, 2026 03:20
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-repo-centralize-package-subpaths branch from f064103 to e00f4b9 Compare July 14, 2026 17:03
@jrusso1020
jrusso1020 force-pushed the 07-10-test-repo-execute-packed-subpaths branch 3 times, most recently from ab8fd5d to b6b78b5 Compare July 14, 2026 17:35
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-repo-centralize-package-subpaths branch 2 times, most recently from 8fe514e to 8bcba53 Compare July 14, 2026 17:57
@jrusso1020
jrusso1020 force-pushed the 07-10-test-repo-execute-packed-subpaths branch from b6b78b5 to 6be6180 Compare July 14, 2026 17:57
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-repo-centralize-package-subpaths branch from 8bcba53 to 3f6ecad Compare July 14, 2026 18:06
@jrusso1020
jrusso1020 force-pushed the 07-10-test-repo-execute-packed-subpaths branch from 6be6180 to 78888dd Compare July 14, 2026 18:06
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-repo-centralize-package-subpaths branch from 3f6ecad to dfddd47 Compare July 14, 2026 19:37
@jrusso1020
jrusso1020 force-pushed the 07-10-test-repo-execute-packed-subpaths branch from 78888dd to 3a5655d Compare July 14, 2026 19:37
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-repo-centralize-package-subpaths branch from dfddd47 to b2caf3f Compare July 14, 2026 19:42
@jrusso1020
jrusso1020 force-pushed the 07-10-test-repo-execute-packed-subpaths branch from 3a5655d to d092cdb Compare July 14, 2026 19:42
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-repo-centralize-package-subpaths branch from b2caf3f to d85a2b5 Compare July 14, 2026 19:47
@jrusso1020
jrusso1020 force-pushed the 07-10-test-repo-execute-packed-subpaths branch 2 times, most recently from b89ebfb to c671bec Compare July 14, 2026 19:49
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-repo-centralize-package-subpaths branch from d85a2b5 to 5a5fa1b Compare July 14, 2026 19:49
@jrusso1020
jrusso1020 force-pushed the 07-10-test-repo-execute-packed-subpaths branch from c671bec to e6dfdac Compare July 14, 2026 19:55
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-repo-centralize-package-subpaths branch from 5a5fa1b to 9b655eb Compare July 14, 2026 19:55
@jrusso1020

jrusso1020 commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator Author

Fixed the exact-head Build failure in 634cd71. The packed browser-consumer check had classified parsers Node-only ./ff-binaries and ./asset-resolution exports as browser-safe, so Vite attempted to bundle their fs, path, and child_process imports. Their descriptors now correctly declare bun,node only.

Validated with bun run sync:package-subpaths, bun run check:package-subpaths, and bun run verify:packed-manifests: 12 manifests are publish-safe; the packed consumer resolves 100 exports, executes 95 Node exports, and passes TypeScript/Vite resolution plus CLI startup. Restacked and republished #2169#2174; fresh exact-head CI is running.

miguel-heygen
miguel-heygen previously approved these changes Jul 19, 2026

@miguel-heygen miguel-heygen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-head review completed at 634cd719a26742ae92a33c38348da4d8fd37fc52.

The packed-contract verifier now exercises the actual tarballs in environment-appropriate consumers: Node exports are resolved and executed, while browser-declared typed exports are kept live through namespace bindings and bundled with Vite. That specifically prevents sideEffects: false from making the browser check vacuous.

The parser correction is consistent with the implementation: ./ff-binaries and ./asset-resolution import Node built-ins, so declaring them Bun/Node-only fixes the root contract mismatch. The descriptor-driven checks, focused 9/9 test suite, clean diff check, zero unresolved threads, current ancestry, and exact-head CI are all green.

Non-blocking nit: the PR description's 94/89 export counts are stale; the exact-head run reports 100 resolved and 95 executed.

Verdict: APPROVE
Reasoning: The packed-contract gate now detects both published export/alias drift and Node-only entrypoints incorrectly advertised to browser consumers, with meaningful execution/bundling coverage and green exact-head evidence.

-- Magi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants