test(repo): execute packed subpaths#2169
Conversation
554f049 to
81f0609
Compare
e656e66 to
dab294d
Compare
4a8cbbd to
f064103
Compare
dab294d to
72cafdf
Compare
f064103 to
e00f4b9
Compare
ab8fd5d to
b6b78b5
Compare
8fe514e to
8bcba53
Compare
b6b78b5 to
6be6180
Compare
8bcba53 to
3f6ecad
Compare
6be6180 to
78888dd
Compare
3f6ecad to
dfddd47
Compare
78888dd to
3a5655d
Compare
dfddd47 to
b2caf3f
Compare
3a5655d to
d092cdb
Compare
b2caf3f to
d85a2b5
Compare
b89ebfb to
c671bec
Compare
d85a2b5 to
5a5fa1b
Compare
c671bec to
e6dfdac
Compare
5a5fa1b to
9b655eb
Compare
|
Fixed the exact-head Build failure in 634cd71. The packed browser-consumer check had classified parsers Node-only ./ff-binaries and ./asset-resolution exports as browser-safe, so Vite attempted to bundle their fs, path, and child_process imports. Their descriptors now correctly declare bun,node only. Validated with bun run sync:package-subpaths, bun run check:package-subpaths, and bun run verify:packed-manifests: 12 manifests are publish-safe; the packed consumer resolves 100 exports, executes 95 Node exports, and passes TypeScript/Vite resolution plus CLI startup. Restacked and republished #2169–#2174; fresh exact-head CI is running. |
miguel-heygen
left a comment
There was a problem hiding this comment.
Exact-head review completed at 634cd719a26742ae92a33c38348da4d8fd37fc52.
The packed-contract verifier now exercises the actual tarballs in environment-appropriate consumers: Node exports are resolved and executed, while browser-declared typed exports are kept live through namespace bindings and bundled with Vite. That specifically prevents sideEffects: false from making the browser check vacuous.
The parser correction is consistent with the implementation: ./ff-binaries and ./asset-resolution import Node built-ins, so declaring them Bun/Node-only fixes the root contract mismatch. The descriptor-driven checks, focused 9/9 test suite, clean diff check, zero unresolved threads, current ancestry, and exact-head CI are all green.
Non-blocking nit: the PR description's 94/89 export counts are stale; the exact-head run reports 100 resolved and 95 executed.
Verdict: APPROVE
Reasoning: The packed-contract gate now detects both published export/alias drift and Node-only entrypoints incorrectly advertised to browser consumers, with meaningful execution/bundling coverage and green exact-head evidence.
-- Magi

What
Execute every promised packed subpath in clean Node and browser consumers.
Why
Manifest generation alone cannot prove that an exported subpath installs, resolves peers, or bundles in its declared environment.
How
Install packed tarballs, import all Node promises, typecheck consumer code, and run a Vite browser build according to descriptor environments.
Test plan