Repository navigation
Skip doc reproducibility test if document is a copy - #2672
Merged
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
This was referenced Oct 28, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the change to skip reproducibility checks on automatically copied documentation.
No open issues 🎉
What changed in this PR
Avoids documentation reproducibility failures in release-branch doc sync PRs by skipping regeneration checks when a document starts with the automatic-copy notice.
Changes:
- Adds a shared copy-notice detector supporting LF and CRLF line endings.
- Tests copied documents, ordinary content, and prefix edge cases.
- Skips crypto documentation and user guide reproducibility checks for copied documents.
| File | Description |
|---|---|
eng/_util/internal/docutil/docutil.go |
Adds automatic-copy notice detection. |
eng/_util/internal/docutil/docutil_test.go |
Tests notice detection and line-ending handling. |
eng/_util/cmd/updatecryptodocs/updatecryptodocs_test.go |
Skips both reproducibility checks for copied documents. |
Review effort: Balanced
This was referenced Oct 28, 2026
Quim Muntal (qmuntal)
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes test failure in doc sync PRs like these by skipping the doc reproducibility test when the copy prefix is present:
microsoft/mainintomicrosoft/release-branch.go1.26#2670microsoft/mainintomicrosoft/release-branch.go1.27#2671Tested locally on top of #2670:
_utiltests passed.