Skip to content

Add a README and license files to ed-claude - #54

Merged
setoelkahfi merged 1 commit into
developmentfrom
docs/ed-claude-readme
Nov 2, 2026
Merged

setoelkahfi merged 1 commit into
developmentfrom
docs/ed-claude-readme

Conversation

@setoelkahfi

Copy link
Copy Markdown
Collaborator

ed-claude 1.4.0 has no README on crates.io, and the published package has no license files. Cargo picks up README.md from the crate dir on its own, but it only packages license files that sit in that dir. The other crates already have both.

  • Adds crates/ed-claude/LICENSE-MIT and LICENSE-APACHE, byte-for-byte copies of the root files.
  • Adds crates/ed-claude/README.md in the style of the sibling crates. I copied the example into a scratch test and built it, then deleted the test.
  • Points the Docs list in the root README at crates/ed-claude/README.md.

cargo package -p ed-claude --locked --list now lists all three files, and cargo fmt --check passes.

A published version can't change, so the 1.4.0 page stays bare. The README shows up with the next release, which also needs the dev-dep fix in #53.

ed-acp-tauri and ed-agent-ffi have no README or license files either. They can get the same treatment in a follow-up.

crates.io shows no README for ed-claude 1.4.0, and the package carries
no license files, because cargo only packages the ones that sit in the
crate directory. Copy the two license files from the root, as the other
crates do, and add a README in the same style.

The root README's Docs list now links the new file.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@setoelkahfi setoelkahfi self-assigned this Nov 2, 2026

@sigit-code-review sigit-code-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds a crate-level README for ed-claude with an ed-acp integration example and API-key notes, copies the MIT and Apache-2.0 license files into the crate, and repoints the two root README references for ed-claude to the new README path. The license copies match the root texts, and the packaging and formatting checks noted in the PR are consistent with the changed files. No issues found.


Automated review by siGit Code Review · commit 41b1853 · see the review dashboard

@setoelkahfi
setoelkahfi merged commit dfcc0dc into development Nov 2, 2026
1 check passed
@setoelkahfi
setoelkahfi deleted the docs/ed-claude-readme branch November 2, 2026 13:03
This was referenced Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant