Repository navigation
[codex] Enforce exact managed config values - #28409
abhinav-oai wants to merge 10 commits into
Conversation
29eaa11 to
342a03b
Compare
189385c to
6362b97
Compare
2506008 to
342a03b
Compare
342a03b to
822b6dc
Compare
6362b97 to
a3edbe9
Compare
| /// If `false`, the model can never use a login shell: `login = true` | ||
| /// requests are rejected, and omitting `login` defaults to a non-login | ||
| /// shell. | ||
| #[serde(default = "default_allow_login_shell")] |
There was a problem hiding this comment.
Final config still defaults with unwrap_or(true)
This change is just to avoid emitting a confusing warning to users
allow_login_shelldeserialized asSome(true)is the same as the user explicitly settingtrue- if requirements are setting
falsewe'd emit the warning
| use codex_config::Sourced; | ||
| use codex_config::config_toml::ConfigToml; | ||
| use codex_config::types::FeedbackConfigToml; | ||
|
|
There was a problem hiding this comment.
Later PRs will grow this with managed auth/bootstrap, OTEL, and shell-policy application
Goal was to keep those concerns out of the already-large final Config constructor
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 79dd7b63ee
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 498a1b3c28
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
Summary
Extends
requirements.tomlwith exact-value enforcement for:sqlite_homelog_dirmodel_catalog_jsoncheck_for_update_on_startupallow_login_shellfeedback.enabledwindows.sandbox_private_desktopWe emit a startup warning if these new requirements overrule a user's config.
Also centralizes config-loading in
core/src/config/requirements.rsso we can apply requirements before Codex computes and exposes its final config.App-server and replay
configRequirements/readand its generated schemas expose the exact managed values.config/readreports the runtime-effective values after requirements are applied.configRequirementReadonly.Stack
PRs: #28411 → #28409 → #28410 → #28412 → #28414 → #28413
abhinav/requirements-shell-rulesabhinav/requirements-exact-valuesabhinav/requirements-auth-bootstrapabhinav/requirements-otelabhinav/requirements-shell-policyabhinav/requirements-app-server-api