Repository navigation
[codex] Enforce managed shell environment policy - #28414
Closed
abhinav-oai wants to merge 4 commits into
Closed
abhinav-oai wants to merge 4 commits into
abhinav-oai wants to merge 4 commits into
Conversation
This was referenced Jun 15, 2026
abhinav-oai
force-pushed
the
abhinav/requirements-otel
branch
from
June 16, 2026 00:16
3e9e228 to
3485445
Compare
abhinav-oai
force-pushed
the
abhinav/requirements-shell-policy
branch
2 times, most recently
from
June 16, 2026 05:34
e18d756 to
a2021d4
Compare
abhinav-oai
force-pushed
the
abhinav/requirements-otel
branch
from
June 16, 2026 05:34
3485445 to
9ebf3e5
Compare
abhinav-oai
force-pushed
the
abhinav/requirements-shell-policy
branch
from
June 16, 2026 05:40
a2021d4 to
e18d756
Compare
abhinav-oai
force-pushed
the
abhinav/requirements-otel
branch
2 times, most recently
from
June 16, 2026 07:23
3485445 to
348d5a7
Compare
abhinav-oai
force-pushed
the
abhinav/requirements-shell-policy
branch
from
June 16, 2026 07:23
e18d756 to
de3f19d
Compare
abhinav-oai
force-pushed
the
abhinav/requirements-otel
branch
from
June 16, 2026 07:36
348d5a7 to
ed9504c
Compare
abhinav-oai
force-pushed
the
abhinav/requirements-shell-policy
branch
from
June 16, 2026 07:36
de3f19d to
7e027e5
Compare
abhinav-oai
force-pushed
the
abhinav/requirements-otel
branch
from
June 16, 2026 07:40
ed9504c to
4657ed3
Compare
abhinav-oai
force-pushed
the
abhinav/requirements-shell-policy
branch
from
June 16, 2026 07:40
7e027e5 to
9799062
Compare
Contributor
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
shell_environment_policyenforcement torequirements.tomlusing the keyedfiltersrepresentation introduced at the bottom of this stack.Why
Managed shell policy must compose safely across requirement sources. Legacy arrays cannot compose per pattern because each higher layer replaces the entire array.
Ordinary
config.tomlcontinues accepting either representation to ease migration.requirements.tomlaccepts only keyed filters, isolating compatibility and making future array deprecation simpler.Semantics
filtersand reject legacyexclude/include_onlyarrays.inheritandignore_default_excludesuse the highest-priority specified value.setcomposes by environment-variable name; keys compose case-insensitively on Windows.filterscomposes by pattern; the highest-priority action wins for the same pattern.setentries that would reintroduce a blocked variable.setentries are applied afterward and may deliberately re-add a variable.This PR does not make shell snapshots policy-aware.
experimental_use_profileReview traced the runtime behavior to #5278, which silently removed the execution plumbing for shell-profile loading while leaving the config field behind. No usage regressions were reported after that removal, so this stack removes the inert
experimental_use_profile/use_profilefield rather than reviving it or exposing it through managed requirements.Stack
PRs: #28411 → #28409 → #28410 → #28412 → #28414 → #28413
abhinav/requirements-shell-rulesabhinav/requirements-exact-valuesabhinav/requirements-auth-bootstrapabhinav/requirements-otelabhinav/requirements-shell-policyabhinav/requirements-app-server-api