Repository navigation
[codex] Enforce managed OTEL configuration - #28412
Closed
abhinav-oai wants to merge 2 commits into
Closed
abhinav-oai wants to merge 2 commits into
abhinav-oai wants to merge 2 commits into
Conversation
This was referenced Jun 15, 2026
abhinav-oai
force-pushed
the
abhinav/requirements-auth-bootstrap
branch
from
June 16, 2026 00:16
5e301da to
e843d2e
Compare
abhinav-oai
force-pushed
the
abhinav/requirements-otel
branch
2 times, most recently
from
June 16, 2026 05:34
3485445 to
9ebf3e5
Compare
abhinav-oai
force-pushed
the
abhinav/requirements-auth-bootstrap
branch
2 times, most recently
from
June 16, 2026 05:40
38a371f to
e843d2e
Compare
abhinav-oai
force-pushed
the
abhinav/requirements-otel
branch
from
June 16, 2026 05:40
9ebf3e5 to
3485445
Compare
abhinav-oai
force-pushed
the
abhinav/requirements-auth-bootstrap
branch
from
June 16, 2026 07:23
e843d2e to
f1faa49
Compare
abhinav-oai
force-pushed
the
abhinav/requirements-otel
branch
2 times, most recently
from
June 16, 2026 07:36
348d5a7 to
ed9504c
Compare
abhinav-oai
force-pushed
the
abhinav/requirements-auth-bootstrap
branch
from
June 16, 2026 07:40
a10cd3c to
d3055b2
Compare
abhinav-oai
force-pushed
the
abhinav/requirements-otel
branch
from
June 16, 2026 07:40
ed9504c to
4657ed3
Compare
Contributor
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds managed
otelsupport torequirements.toml, including composition across requirement sources and enforcement over ordinary config.OTEL values use different composition rules depending on whether they are atomic or keyed.
Why
Treating OTEL as either one scalar or one recursively merged object is unsafe. Scalars can be independent, exporters contain coupled endpoint/protocol/header/TLS settings, and metadata maps should compose without discarding unrelated entries.
This PR keeps layer composition, runtime enforcement, and telemetry validation in one reviewable contract.
Semantics
log_user_promptandenvironmentare independent exact values.exporter,trace_exporter, andmetrics_exporterare each atomic:span_attributescomposes by key; required values replace matching configured keys while unrelated keys remain.tracestatecomposes by member and field key.analytics.enabledgate.Stack
PRs: #28411 → #28409 → #28410 → #28412 → #28414 → #28413
abhinav/requirements-shell-rulesabhinav/requirements-exact-valuesabhinav/requirements-auth-bootstrapabhinav/requirements-otelabhinav/requirements-shell-policyabhinav/requirements-app-server-api