Repository navigation
[rustdoc] Add the Dyn Compatibility heading all the time in the sidebar since it is always in the doc - #164268
Merged
Conversation
rustbot
added
S-waiting-on-review
Member
|
This is change in the frontend, r? rustdoc-frontend |
This comment has been minimized.
This comment has been minimized.
Contributor
|
Can I get a screenshot for the |
Member
Author
|
It's in #164266. :) Rebasing this PR. |
GuillaumeGomez
force-pushed
the
dyn-compatibility
branch
from
October 15, 2026 18:54
9e28871 to
74b2955
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
dyn-compatibility
branch
from
October 15, 2026 21:22
74b2955 to
2cabd11
Compare
Member
Author
|
And updated the test too. |
Contributor
|
Thanks! @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 18, 2026
…r=lolbinarycat [rustdoc] Add the Dyn Compatibility heading all the time in the sidebar since it is always in the doc The 3 first commits come from rust-lang#164266. While working on it, I realized that even though we added a condition for the sidebar heading, we always have: <img width="520" height="146" alt="image" src="https://github.com/user-attachments/assets/94a7c109-6cc0-4a37-831b-7e40a06f44a4" /> So there should be a heading to reflect it. r? @Urgau
rust-bors
Bot
added
the
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
rust-bors
Bot
removed
the
S-waiting-on-bors
… it is always in the code
GuillaumeGomez
force-pushed
the
dyn-compatibility
branch
from
October 19, 2026 10:10
2cabd11 to
b37c430
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
@bors r=lolbinarycat rollup |
Contributor
rust-bors
Bot
added
the
S-waiting-on-bors
rust-bors
Bot
removed
the
S-waiting-on-author
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-author
Contributor
|
❌ Commit b37c430 has been unapproved due to PR CI failure. Reapprove it with |
Member
Author
|
@bors r=lolbinarycat rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 20, 2026
Rollup of 5 pull requests Successful merges: - #164568 (Exclude MaybeDangling like types from SROA) - #163771 (update {Ipv4Addr,Ipv6Addr}::is_global to match IANA registries) - #164268 ([rustdoc] Add the Dyn Compatibility heading all the time in the sidebar since it is always in the doc) - #164581 (Revert "Remove indirection for `Expr` in `Body`") - #164606 (triagebot: Delete the libs ad-hoc group)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 20, 2026
Rollup merge of #164268 - GuillaumeGomez:dyn-compatibility, r=lolbinarycat [rustdoc] Add the Dyn Compatibility heading all the time in the sidebar since it is always in the doc The 3 first commits come from #164266. While working on it, I realized that even though we added a condition for the sidebar heading, we always have: <img width="520" height="146" alt="image" src="https://github.com/user-attachments/assets/94a7c109-6cc0-4a37-831b-7e40a06f44a4" /> So there should be a heading to reflect it. r? @Urgau
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 3 first commits come from #164266. While working on it, I realized that even though we added a condition for the sidebar heading, we always have:
So there should be a heading to reflect it.
r? @Urgau