[ezequielzacca]

This step's own changes: compare with #825. The diff of this PR also holds every earlier step of #815, since a PR from a fork can only target this repository's branches.

Summary

Step 5b-4 of #815 (data-driven item tooltips; design). Stacked on #825 (→ #824 → … → #813): only the last commit, feat(items): the descriptions' repeated texts are written once, is this step.

The descriptions moved into data in steps 2–5a repeated themselves. There were 263 text lines but only 147 distinct texts, each copy with its translations. This step writes each repeated text once. No tooltip changes.

Shared texts

25 texts that several items repeated are shared texts of Tooltip.json now, and each line names one ("text": "@increaseSpeed"). That turns 150 copies into one each. The most repeated:

• "Increase speed" ×22;
• the CS team message ×12;
• "You can achieve special items with combinations." ×11;
• "Automatic HP recovery 3%" ×8;
• "It's a box containing various items." ×6.

The line keeps its own color, levels and conditions. For example, "Automatic HP recovery 3%" is blue on some items and white on others.

A line's own values

The wings, capes and pets had ten versions of "Increase/Absorb {table}% of Damage", differing only in the table name. A description line can now name the value of its placeholder, as a layout line does since #824:

{"text": "@damageIncrease", "values": {"percent": "wingDamageIncrease3rd"}},
{"text": "@damageAbsorb", "values": {"percent": "wingDamageAbsorb3rd"}}

That gives two shared texts, "Increase {percent}% of Damage" and "Absorb {percent}% of Damage", where there were ten.

Values by item level

An item can give its description's own placeholders a value for each item level. A value is a text with its translations, or a shared text. The Fruits had two lines per stat at each of their five levels, and now have two lines:

"description": [
  {"text": {"en": "{stat} Increases 1~3 stat points", …}, "levels": [0, 4]},
  {"text": {"en": "{stat} Possible to decrease stat 1~9 point", …}, "levels": [0, 4]},
  …
],
"levelValues": {"stat": [{"en": "ENG", "de": "ENG", …}, {"en": "STA", "de": "VIT", …}, …, {"en": "Command", "de": "Führung", …}]}

Placeholders can therefore be text as well as numbers now. The same mechanism can later carry the Talisman of Mobility's saved location, or the Transformation Ring's monster by level (step 5d).

Checks

Errors when the data loads, with the meant name suggested for a typo:

• a line's values naming neither a built-in value nor a table;
• a level value named like a built-in value or a table;
• a level value with placeholders, or a missing @text;
• a line that shows a level value at a level the value doesn't have.

A level value that no line shows is a warning. Shared texts in descriptions go through the same placeholder checks as texts written in place.

Not done, as discussed in #815

• Profile-bound values. The design had each stat profile name the table a placeholder means. But items that share a profile use different tables:

  • thirdTierWing's wings and its capes 12/40 and 12/50;
  • smallWing's wings and its small capes;
  • the two secondTierCape capes.

  So the line's own values does it, without splitting profiles.

Verified

• "Every item's tooltip is as recorded" is unchanged for every item, at every level, in all six variants and for both heroes. It records English only.
• The game's tooltip-snapshot is identical before and after for the Dark Knight in English, German and Russian, and for the Dark Wizard in English: 91,104 tooltips each.
• The conversion script also checked that every translation is rebuilt exactly.

Found while doing this

Several translations of the wing texts carry English leftovers. Examples:

• Spanish: "Aumenta el daño de {percent}% of";
• Portuguese: "Absorver Dano {percent}% of";
• Russian: "Увеличение {percent}% of урона".

Some Fruits stat words are machine-translation slips:

• Indonesian: "Bahasa Inggris" ("English language") for ENG;
• Chinese: "通用人工智慧" ("artificial general intelligence") for AGI.

Each is one shared text or one list now, so each fix is one place. They're left as they were, to keep this PR free of tooltip changes.

Screenshots

The same tooltips before (#825) and after this PR, for a level 400 Dark Knight. They're identical, because only the data behind them changed. The data under each pair is shown in English only; the files keep every translation.

Wing of Storm +15

The shared @damageIncrease and @damageAbsorb, each with the wing's table as the line's values, and the shared @increaseSpeed.

	Legacy theme	Modern theme
Before
After

The item's data (English only)

{
  "number": 36,
  "name": "Wing of Storm",
  "tags": [
    "valuable"
  ],
  "description": [
    {
      "text": "@damageIncrease",
      "values": {
        "percent": "wingDamageIncrease3rd"
      }
    },
    {
      "text": "@damageAbsorb",
      "values": {
        "percent": "wingDamageAbsorb3rd"
      }
    },
    {
      "text": "@increaseSpeed"
    }
  ]
}

Its shared texts in Tooltip.json (English):

"damageAbsorb": "Absorb {percent}% of Damage"
"damageIncrease": "Increase {percent}% of Damage"
"increaseSpeed": "Increase speed"

Command Fruits +4

{stat} comes from the item's levelValues: "Command" at +4 ("Führung" in German). Ten lines are two now.

	Legacy theme	Modern theme
Before
After
Before, German
After, German

The item's data (English only)

{
  "number": 15,
  "name": "Fruits",
  "tags": [
    "valuable"
  ],
  "description": [
    {
      "text": "{stat} Increases 1~3 stat points",
      "levels": [
        0,
        4
      ]
    },
    {
      "text": "{stat} Possible to decrease stat 1~9 point",
      "levels": [
        0,
        4
      ]
    },
    {
      "text": "It can be used with item removed.",
      "color": "darkRed",
      "levels": [
        0,
        4
      ]
    },
    {
      "text": "Can be equipped by Dark Lord",
      "levels": [
        4,
        4
      ]
    }
  ],
  "levelValues": {
    "stat": [
      "ENG",
      "STA",
      "AGI",
      "STR",
      "Command"
    ]
  }
}

Related issues

Step 5b-4 of #815. Builds on #825, #824, #823, #822, #821, #820, #819, #818, #817, #816 and #813.

Checklist

• I have read and followed docs/CODING_RULES.md.
• I have built the project locally (see docs/build/README.md).
  • Windows x64 Release: all 1007 tests pass.
  • The new ones cover a line's values, level values and their checks.
  • The recorded tooltip test is unchanged.
  • Changed lines pass clang-format 21.1.8 as CI checks them.
  • In game: tooltip-snapshot before and after in three languages, and the screenshots above in both themes.
• Changes are focused on one concern; the diff is as small as it reasonably can be.

[ezequielzacca]

Thanks. Both are covered now.

• Conversion: the only coverage was the bmd round trip, which runs in editor builds only. "Converting from the item attribute keeps the client-only fields" is a plain unit test now: it fills an item with description lines (a written text with translations, values, a when, a color and levels; a blank line; a shared @text) and with level values (written and shared). It checks that CopyFieldsNotInItemAttribute keeps them whole, while the attribute's own fields stay the imported ones. From feat(items): the tooltip's item names come from the data (#815 step 5d-1) #833 on it covers the name lines too.
• Unrelated items: this PR's snapshot file is unchanged from feat(items): the tooltip's durability lines come from the data #825. Every item's tooltip, in the eleven variants test(items): every item's tooltip in a test, against recorded hashes #822 records for both heroes, is the same before and after the texts became shared.