Repository navigation
docs: ADR 0002 and NEXT.md 0.4 record the lint toolchain as built - #127
Merged
Merged
Conversation
ADR 0002 gains an "As built (2026-10-06)" subsection, following the as-built reconciliation pattern; the decision text is unchanged. It records what matches (the ESLint flat config and slice-boundary rule, five CI jobs, the pre-commit hook) and what differs (typescript-eslint's recommended preset, no @nuxt/eslint, vue-tsc in CI only per #82, and relative imports passing the slice rule). NEXT.md 0.4 notes what shipped. Closes #126. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 6, 2026
Open
xcjs
approved these changes
Oct 6, 2026
xcjs
left a comment
Owner
There was a problem hiding this comment.
Approved as non-author. Verified against main at 05fa79d: every cited line reference checks out (eslint.config.mjs 23/44/45/114, ci.yml 10/27/45/63/85, package.json 13/15/20, .husky/pre-commit 1-2). The Matches/Differs split is honest, the slice-rule relative-import caveat is real (no cross-slice relative imports on main), and noting ESLint is not yet a required branch-protection context is a useful flag for a follow-up to #104.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 0's exit criterion is that the ADRs match the code. After #94, two records didn't:
docs/adrs/README.md, this appends an As built (2026-10-06) subsection with file references and leaves the decision text unchanged.recommendedpreset rather than the type-checked ones, and no@nuxt/eslint.vue-tscruns in CI only, for the reason 0.4 ESLint flat config and vue-tsc in pre-commit #82 gives. The slice rule doesn't see relative imports.vue-tsc. A short "As built" note now says what shipped.A correction to my #94 review: I said keeping
vue-tscin CI matches ADR 0002. It matches the hackathon golden path, which ADR 0012 made historical. The decision itself asks for enforcement "in CI and pre-commit", so the new section lists it under "Differs".Closes #126.
Verification
eslint.config.mjs,package.json,.husky/pre-commit,.github/workflows/ci.yml, and branch protection through the branch API.🤖 Generated with Claude Code