Repository navigation
fix(coord): make coord.sh's scope checks work on macOS and with glob scopes - #88
Merged
Merged
Conversation
…scopes
claim: compare Files entries as exact strings (grep -qxF, like coord.ps1's
-contains) and quote the lists so entries are never glob-expanded. macOS
BSD grep rejected a glob entry such as tests/** as a regex
('repetition-operator operand invalid'), which aborted the claim.
review: check PR paths against Files entries the way coord.ps1 does
(wildcard either way, or a prefix match with trailing '*' and '/' trimmed)
via a new in_scope helper. The old substring test reported every path
under a glob scope as undeclared.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 task done
The overlap loop ended on 'grep ... && echo', so a final non-match left the command substitution with status 1, and set -e exited claim silently whenever another open issue declared Files. Use if/fi so a miss is not an error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The loop emitted 'number<TAB>body' and read it line by line, so every
line of a multi-line body was treated as an issue number ('invalid issue
format' noise; a body line starting with digits would be checked as that
issue). Only the number is used, so emit only the number.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 3, 2026
Open
xcjs
approved these changes
Oct 3, 2026
xcjs
left a comment
Owner
There was a problem hiding this comment.
Reviewed: in_scope() mirrors coord.ps1 wildcard semantics without regex/expansion (BSD+GNU safe), the claim clash loop no longer trips set -e on a non-match, and the review scope check uses in_scope. Fixes the exact macOS failures we saw with glob scope entries. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coord.sh claimfailed on macOS, and on any platformclaimandreviewmisbehaved around## Filesscopes. This PR has three fixes incoord.sh. The first two bring it in line withcoord.ps1:grep -xas a regex. The system grep (BSD grep 2.6.0-FreeBSD) rejects a glob liketests/**("repetition-operator operand invalid"), and the claim aborted. Entries are now compared as exact strings (grep -qxF, like the PowerShell helper's-contains), and the lists are quoted so the shell never glob-expands an entry.grep … && echo, so a final non-match left the command substitution at status 1, andset -equietly exitedclaimwhenever another open issue declared Files. It now usesif … fi.number<TAB>bodyline by line, so each line of a multi-line body was treated as an issue number ("invalid issue format" noise). A body line starting with digits would have been checked as that issue. It now emits just the number.coord.ps1does it: a wildcard match either way, or a prefix match on the entry with trailing*and/trimmed. That's a newin_scopehelper. Before, a substring test reported every file under a glob scope (liketests/**) as undeclared.Verification
bash -n coord.shis clean.tests/**overlap with 0.1 Playwright end-to-end test of the core loop #79 before Ask Agent to Fix does nothing when Agent Chat is closed #92's Files were narrowed. It also marked 0.1 Playwright end-to-end test of the core loop #79 in-review against PR test: e2e Playwright test of the core loop (#79) #91, whose paths sit undertests/**, which main'sreviewcheck rejects.in_scopepasses 13/13 cases:tests/**coverstests/e2e/core-loop.spec.ts;README.mdcovers only itself;docs/coversdocs/x.md;app/features/os/**excludesapp/features/apps/x.ts.🤖 Generated with Claude Code