feat: integrate IsaacGym fixed model variants (#1577) - #1582
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unisim-core>=1.4.1in the default and ROCm dependency profiles. The optionalsuperdexextra keeps its own>=1.4.0constraint: SuperDex has no 1.4.1-specific change, and the base requirement already forces every installed profile to 1.4.1 or newer. UniLab's package version is unchanged.Closes #1578.
Roadmap: #1577.
Benchmark decision: #1579.
Upstream release evidence
d4ee22f717ba0160178a2d7e7bf786702dd7420a.ci.ymlrun34946318565: success.v1.4.1release run34946437978: build, sdist verification, and PyPI trusted publishing succeeded.unisim_core-1.4.1.tar.gzverified.Validation
Commands run on final local head after installing the published dependency:
Results:
make test-all: PASSunisim-core==1.4.1.uv lock --check: PASS.Benchmark results and boundaries are recorded in #1579 (comment).
Impact
Artifacts
Checklist