chore: remove obsolete dead code and stale references - #1593
Merged
Merged
Conversation
Delete zero-reference scripts, assets, and the unused monitoring utility left over from the Unitree downstream migration; port the drake batch-pool test fixture from go1 to go2; drop stale doc and config references to the removed modules. Refs #1590
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes obsolete dead code and stale references left over from the Unitree downstream migration and earlier cleanups:
src/unilab/utils/monitoring.py(zero references),scripts/convert_motion_29dof_to_23dof.py,scripts/benchmark/env/benchmark_postprocess.py,scripts/benchmark/xmls/humanoid/humanoid100.xml, the emptysrc/unilab/assets/motions/g1/23dof_amp/.gitkeep, and the orphanedsrc/unilab/assets/robots/hfields/hfield.png.tests/base/backend/test_drake_batch_pool.pynow uses the in-repo go2 asset instead of the removed go1 fixture..gitignore, pyproject coverage/pyright omits, and seed/sim2sim/geometry/device/training references cleaned up accordingly.Explicitly kept (reviewed and deliberately retained): the rough/terrain public API chain, test-only rotation math functions, the
utils/tensortransition shim, and the legacyreward_configbranch.Impact
No runtime/backend/training behavior change; no public contract change.
Validation
make test-allon this head: 1474 passed, 26 skipped (exit 0), including the benchmark smoke suite (34/34 module-mode, 35/35 script-mode).Closes #1590