Repository navigation
Make ed-claude's testkit dev-dep path-only - #53
Merged
Merged
Conversation
…orks cargo-workspaces strips dev-deps that carry a version, which dropped ed-acp-testkit from ed-claude's lock entry and made the --locked publish fail in the v1.4.0 run. A path-only dev-dep is left alone, as in ed-acp and ed-mcp. The release skill now notes the rule. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
![sigit-code-review[bot]](https://avatars.githubusercontent.com/in/3492899?s=60&v=4){kind=small}
There was a problem hiding this comment.
Switches ed-claude's dev-dependency on ed-acp-testkit from a workspace/versioned reference to a path-only one ({ path = "../ed-acp-testkit" }), matching the pattern ed-acp and ed-mcp already use. This prevents cargo-workspaces from stripping the dev-dep during the v1.4.0 publish, which previously made --locked fail. The change is a single line, Cargo.lock is untouched, and the release skill now documents that workspace-member dev-deps must be path-only. No issues found in the diff.
Automated review by siGit Code Review · commit ef48c85 · see the review dashboard
This was referenced Nov 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.4.0 publish run failed on ed-claude. cargo-workspaces strips dev-deps that carry a version, which removed ed-acp-testkit from ed-claude's lock entry, and
--lockedrefused the rewrite. The preflight dry-run doesn't catch it.This switches the dev-dep to
{ path = "../ed-acp-testkit" }, the same pattern ed-acp and ed-mcp use.Cargo.lockis unchanged and the packaged manifest has no ed-acp-testkit. The release skill now says workspace-member dev-deps must be path-only.Tested with
cargo test --locked -p ed-claude, clippy, fmt andcargo package -p ed-claude --locked.