Repository navigation
fix(chat): Ask Agent to Fix reaches the agent when Agent Chat was closed (#92) - #95
Merged
Merged
Conversation
…sed (#92) askFix reopened the chat window, but its ref was still null in the same tick, so sendMessage was skipped silently. Wait one tick for the window to mount before sending. A new e2e spec closes Agent Chat, breaks an app, and asks the agent to fix it (red before this change, green after). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 3, 2026
Open
m-vawter
approved these changes
Oct 3, 2026
m-vawter
left a comment
m-vawter
left a comment
Collaborator
There was a problem hiding this comment.
Approving at @xcjs's request on the hub ("m-vawter/gemini: approve + merge #95"). For the record, this commit is from my side: it's the #93 work, re-opened here after its stacked base branch was deleted. So the substantive review is @xcjs's approval on #93, and this is the step the base policy needs. It's the same commit (92032d9) and an identical diff to #93, and CI is green on it.
2 tasks done
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-creation of #93, which GitHub auto-closed (unreopenable) when its stacked base branch test/e2e-core-loop was deleted on the #91 merge. Same head commit, so the prior approval carries over.
Fixes #92. With Agent Chat closed, "Ask Agent to Fix" reopened the chat but never reached the agent.
askFixinapp/app.vuesent through the chat ref in the same tick thatopenBuiltin('chat')queued the window, while the ref was stillnull. It now waits one tick for the window to mount before sending.Verification
tests/e2e/ask-fix-chat-closed.spec.tsfails without the change and passes with it.npm run test:e2e: passed.npm run typecheck: clean.npm run lint:md: 0 errors.Closes #92.